From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 8DA17385842D for ; Fri, 28 Apr 2023 21:54:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8DA17385842D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682718842; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RF+tGLFgHXj+xlDeGFRu5EwrbyN2Z6Wdkf7mLT7h6ZM=; b=N44B6keZBxOdeFlq38e8a7NRx3cwByF5yOHZerybHbpgvEfvBup6jJQTp6GHJ0eyyZdkkj BJagaDuUEsQKC6EkAo3M7hCiQLcCTFW4MopI+f6V2rMEsi3PkJGppFV42gQi1HvJMEGTZH VM4R4jElmh2ZUNvaYotCpscSTaM6ZXk= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-434-LvwHCE8yPamhbrst9_TvNg-1; Fri, 28 Apr 2023 17:54:00 -0400 X-MC-Unique: LvwHCE8yPamhbrst9_TvNg-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3f18c2b2110so488525e9.3 for ; Fri, 28 Apr 2023 14:54:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682718839; x=1685310839; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RF+tGLFgHXj+xlDeGFRu5EwrbyN2Z6Wdkf7mLT7h6ZM=; b=EQhrURGYfrKE9YYrm77fFmqXEWIfhNdTfBzhrJQ4HsKfvZFHMhSTxmOUH8MEY1Fp6n luidE0OTCypuj8hSOeM8k1MfpHO8p6xC/kJJLgCAVbxZHLjoMISbHxRNpjCSjKo/ZV1C r2RWBsWvxPMSFw6F7Anj2XOUVcApXhW8GAis/aztvVL1yJFIUARz3zrROfTi7pASFC8+ kSQaSJ3Uvvqrc1wLqmhzDktmoKu7hcup2MyfEwP3xutzpWdYd4NWLLo2WLmqENaw7u4/ oRontZQ65OlskDmFdNWjZKsDAgZsyv0r0E3r2hTaddlvdEPgd5czwRvezJAj8OVh2nZP ULHQ== X-Gm-Message-State: AC+VfDw2mwAUvyTuRG1LSkzSvjok0Ml/9UcL0VTNQwwD3bQ53aIjtZNj +SEyao4R+ijx4QcG0JWFO06DI88mqfnmnEtdMg95Bgo8dKAYB+0TgV4EnK2AARDbM49gpSjyXK1 JfiZlBQaa2pbYmYOI3ibj0mpbAN0q+g== X-Received: by 2002:a1c:7718:0:b0:3ef:8b0:dbb1 with SMTP id t24-20020a1c7718000000b003ef08b0dbb1mr4860835wmi.7.1682718839442; Fri, 28 Apr 2023 14:53:59 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4bZcI/G4Q/0vXUZFnO5sW53u0HqdXdHIAWw0iCbRJRQFBthcMYI6+FvP9dgFHR6jneBlfSDg== X-Received: by 2002:a1c:7718:0:b0:3ef:8b0:dbb1 with SMTP id t24-20020a1c7718000000b003ef08b0dbb1mr4860831wmi.7.1682718839128; Fri, 28 Apr 2023 14:53:59 -0700 (PDT) Received: from localhost (11.72.115.87.dyn.plus.net. [87.115.72.11]) by smtp.gmail.com with ESMTPSA id o4-20020a056000010400b002fa67f77c16sm21861191wrx.57.2023.04.28.14.53.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Apr 2023 14:53:58 -0700 (PDT) From: Andrew Burgess To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH 0/5] Fixes for per-inferior settings and $_gdb_setting_str() In-Reply-To: <5eab0407-31ba-ffd4-237d-81882f8e3a28@simark.ca> References: <636ce26d-19e9-124e-5323-8362a9928bcd@simark.ca> <5eab0407-31ba-ffd4-237d-81882f8e3a28@simark.ca> Date: Fri, 28 Apr 2023 22:53:57 +0100 Message-ID: <87ildfad1m.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Simon Marchi writes: > On 4/17/23 14:09, Simon Marchi via Gdb-patches wrote: >> On 4/4/23 08:45, Andrew Burgess via Gdb-patches wrote: >>> While working on another patch I spotted that >>> $_gdb_setting_str("args") wasn't working correctly. Turns out args, >>> cwd, and inferior-tty all have the same problems. This series >>> resolves these issues. >> >> That rang a bell, it's because I have fixed some of these downstream in >> ROCgdb, and haven't sent it upstream yet. The downstream commit is >> here: >> >> https://github.com/ROCm-Developer-Tools/ROCgdb/commit/54d0a79614071fd62df5e2dfe793ff26cc7e31e6 >> >> I'll take a look at your patches, I presume that they will do mostly the >> same thing. And if my patch does more (according to the commit message, >> it fixes "remote exec-file" and "tdesc filename"), I can send what >> remains after. > > So, my patch adds some tests for gdb.parameter (Python), MI and the with > command. However, they are sprinkled in different files. I like that > you have a test file specifically to exercise the settings that are > per-inferior. Your test could probably be augmented to exercise all > these ways to get a setting. > > You series looks good to me, up to you if you want to merge it as-is or > improve it based on what I had. I reworked the tests taking onboard some of the ideas from your tests, and pushed this series. Do you plan to upstream your patch anytime soon? I had been planning to look at other per-inferior settings once this series was merged, but I don't want to tread on your toes any more than I already have... Thanks, Andrew