From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 41A0F3858D37 for ; Thu, 27 Apr 2023 12:58:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 41A0F3858D37 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682600311; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3+GS5qAC1zf9w2xz5IsT8vAyOpFPzSA2+fklx3BueCg=; b=jQhdFycxgjP//Kr4uaWhRDf0TYc4o1mtYtCnx21HUuIp9osuGV7m/7lp/Ut8ezs7Hgtste HVdyx97Omb0pWMDh3IuiTg4IszElTYx1bUg+6t+KkO9TSsuPQonj7jWkYplqxMHdx9AEhh vPRqHEKAPlmXtd93VjHo7iFV8k0XAWI= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-203-c7MW_aVPOsiujJhGEf6k3A-1; Thu, 27 Apr 2023 08:58:27 -0400 X-MC-Unique: c7MW_aVPOsiujJhGEf6k3A-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3f1912ed0daso27811905e9.1 for ; Thu, 27 Apr 2023 05:58:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682600305; x=1685192305; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=3+GS5qAC1zf9w2xz5IsT8vAyOpFPzSA2+fklx3BueCg=; b=Z8FruDzae4LmCkvZeQVNcMKjehkexeaJ1j9OWLnn24kN1aMqhg3IW3/3pKSU98GCL+ d4dL7+ycyvY3T4kL7AS4LoLbp4cG5DUqa0bTYaKV6km5PSEX4ux1zzLsfZHlrOoRojzt nL9OS7yH6OzF7rRnn0f/gLWX7pDkVNvq/hh2qa/7Qw3J8MfPF6OwFetYAnugq0AMlNz2 aGBh8AXSjG3JgM2Tgc1LQi/VQTna0y1e8aHTI4e6WG96TyjFcYJw67N9uQe8OxjHgf0u WqQH0ZZ00rdTeKzKD88yqgxB5Z/8L/c+p4V0nKlnbp/Xh5LxjF0fosFjYQK85+P4yRw9 Tdeg== X-Gm-Message-State: AC+VfDwEtPIQt9Rst9kk+gpjydxNS6+W/qLiJUM2Ru+gLWAWxI4qsfuf vdv49QPpSC1pgRwqWEUnG+2IbSJ7kr3YtBI26cugUloF+rt9i2/7gJo0IpBM0M+HnSDnpiuqrVn jtBjDHA8X7e5VTSRxDb4zbT5TjUQtJg== X-Received: by 2002:a7b:c4cd:0:b0:3f0:9a90:a5e7 with SMTP id g13-20020a7bc4cd000000b003f09a90a5e7mr1422122wmk.28.1682600305197; Thu, 27 Apr 2023 05:58:25 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7qT/P3GknzDP6/iEfP9NtFMYhwIKqAx2IW99JSj+ELHnwOcGc7yzdcDAqsiX+DEG8FuCqAkA== X-Received: by 2002:a7b:c4cd:0:b0:3f0:9a90:a5e7 with SMTP id g13-20020a7bc4cd000000b003f09a90a5e7mr1422111wmk.28.1682600304919; Thu, 27 Apr 2023 05:58:24 -0700 (PDT) Received: from localhost (11.72.115.87.dyn.plus.net. [87.115.72.11]) by smtp.gmail.com with ESMTPSA id b1-20020a5d45c1000000b002fdeafcb132sm18466988wrs.107.2023.04.27.05.58.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Apr 2023 05:58:24 -0700 (PDT) From: Andrew Burgess To: Tom Tromey , Andrew Burgess via Gdb-patches Subject: Re: [PATCH 0/5] gdb/testsuite: stricter matching for gdb_test In-Reply-To: <877cua4hf3.fsf@tromey.com> References: <877cua4hf3.fsf@tromey.com> Date: Thu, 27 Apr 2023 13:58:23 +0100 Message-ID: <87ildhbhxs.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: > > Andrew> The goal of this series is to make the pattern matching in gdb_test > Andrew> stricter with respect to end of line sequences. This encourages us > Andrew> all to be a little more precise when writting the output patterns for > Andrew> use in gdb_test, but I think this is a good thing for GDB - our tests > Andrew> will get a little stricter. > > Andrew> The final patch adds a new feature to gdb_test, a modified version of > Andrew> the '^' anchor, which again, should (I hope) allow us to write > Andrew> stricter output patterns, which I think is a good thing for GDB. > > Thank you for doing this. I read through this and I think it all looks > good, and seems like a worthwhile improvement. > > Reviewed-By: Tom Tromey Pushed. Thanks, Andrew