From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy3-pub.mail.unifiedlayer.com (gproxy3-pub.mail.unifiedlayer.com [69.89.30.42]) by sourceware.org (Postfix) with ESMTPS id F3A453858D32 for ; Mon, 27 Feb 2023 18:05:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F3A453858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw15.mail.unifiedlayer.com (unknown [10.0.90.130]) by progateway5.mail.pro1.eigbox.com (Postfix) with ESMTP id 746431004B4E3 for ; Mon, 27 Feb 2023 18:05:41 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id WhsbpVdwHdUIVWhsbpSAkg; Mon, 27 Feb 2023 18:05:41 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=U89Xscnu c=1 sm=1 tr=0 ts=63fcf0f5 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=m04uMKEZRckA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=zstS-IiYAAAA:8 a=CCpqsmhAAAAA:8 a=QlMQbPHv2iZOSFbxnm4A:9 a=66zSKFQpzMcA:10:demote_shortener_domain_2 a=4G6NA9xxw8l3yy4pmD5M:22 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=aSO+04QATOJ/X/SDxM5CLO2ISnfFti2dm928BYjw34w=; b=sD2aSIltnbpfgNYnRQWvGeDoez w271S8J5HgaQD1qMDFzO62thnhJwQ0ONtGT5iocxWG8L5wVV2ljWSUiGL2p/xCZClYJNdYpifmhbP +FQJeJbJM/rCEtu701YXu8kS1; Received: from 75-166-130-93.hlrn.qwest.net ([75.166.130.93]:53830 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pWhsb-001KVp-5Q; Mon, 27 Feb 2023 11:05:41 -0700 From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix crash with "finish" in Rust References: <20230209192755.498183-1-tom@tromey.com> X-Attribution: Tom Date: Mon, 27 Feb 2023 11:05:37 -0700 In-Reply-To: <20230209192755.498183-1-tom@tromey.com> (Tom Tromey's message of "Thu, 9 Feb 2023 12:27:55 -0700") Message-ID: <87ilfndlvy.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.93 X-Source-L: No X-Exim-ID: 1pWhsb-001KVp-5Q X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-93.hlrn.qwest.net (murgatroyd) [75.166.130.93]:53830 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3020.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey writes: Tom> PR rust/30090 points out that a certain "finish" in a Rust program Tom> will cause gdb to crash. This happens due to some confusion about Tom> field indices in rust_language::print_enum. The fix is to use Tom> value_primitive_field so that the correct type can be passed; other Tom> spots in rust-lang.c already do this. Tom> Note that the enclosed test case comes with an xfail. This is needed Tom> because for this function, rustc doesn't follow the platform ABI. Tom> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30090 I'm going to check this in now. Tom