From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id CC1553858414 for ; Fri, 10 Feb 2023 20:20:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CC1553858414 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id 1645310040605 for ; Fri, 10 Feb 2023 20:20:33 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id QZsnpMAJlVjzQQZsnpWnkj; Fri, 10 Feb 2023 20:20:33 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=bt2JuGWi c=1 sm=1 tr=0 ts=63e6a711 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=m04uMKEZRckA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=zstS-IiYAAAA:8 a=fBbQ_sMwomhV39Ec5U4A:9 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=kc77oHXngFaS/8KQmNwmWikcMHD+pfKH6rftT8YPoF4=; b=ad6Y+khPUA6Ts508hlmirnUH0H mMEDeauilhztAKe/DL6ABq/MEiZb+AbVsNV5mp5xE5i3IZQwZDr2WPa0JFA0GEaDiIquHH4n79a3L vuv1omkYsXlr8mTWzmPnBzHeZ; Received: from 75-166-130-93.hlrn.qwest.net ([75.166.130.93]:40506 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pQZsm-003dLu-Sg; Fri, 10 Feb 2023 13:20:32 -0700 From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 42/47] Turn various value copying-related functions into methods References: <20230209-submit-value-fixups-2023-v1-0-55dc2794dbb9@tromey.com> <20230209-submit-value-fixups-2023-v1-42-55dc2794dbb9@tromey.com> X-Attribution: Tom Date: Fri, 10 Feb 2023 13:20:30 -0700 In-Reply-To: <20230209-submit-value-fixups-2023-v1-42-55dc2794dbb9@tromey.com> (Tom Tromey's message of "Thu, 09 Feb 2023 14:39:03 -0700") Message-ID: <87ilg9gtm9.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.130.93 X-Source-L: No X-Exim-ID: 1pQZsm-003dLu-Sg X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-130-93.hlrn.qwest.net (prentzel) [75.166.130.93]:40506 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3021.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey writes: Tom> This patch turns a grab bag of value functions to methods of value. Tom> These are done together because their implementations are Tom> interrelated. This one turns out to have a bug that I didn't notice first time around -- I didn't check the test results closely enough. Tom> + void contents_copy_raw (struct value *dst, LONGEST dst_offset, Tom> + LONGEST src_offset, LONGEST length) const; Tom> + Tom> + /* A helper for value_from_component_bitsize that copies bits from Tom> + this value to DEST. */ Tom> + void contents_copy_raw_bitwise (struct value *dst, LONGEST dst_bit_offset, Tom> + LONGEST src_bit_offset, LONGEST bit_length) Tom> + const; The patch adds const here, but it wasn't there earlier. This causes the code to pick up the new overload of contents_all_raw (also added in this patch) and then not correctly allocate the value's contents I've undone this part. I removed the approved-by from this patch for v2 since it changed significantly. Tom