From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from qproxy5-pub.mail.unifiedlayer.com (qproxy5-pub.mail.unifiedlayer.com [69.89.21.30]) by sourceware.org (Postfix) with ESMTPS id 09EB03832C6F for ; Tue, 31 Jan 2023 14:45:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 09EB03832C6F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by qproxy5.mail.unifiedlayer.com (Postfix) with ESMTP id C3F97802E885 for ; Tue, 31 Jan 2023 14:20:03 +0000 (UTC) Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id B5D9F100478D3 for ; Tue, 31 Jan 2023 14:19:23 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id MrTnp1CpkIqHFMrTnpnco3; Tue, 31 Jan 2023 14:19:23 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=d/AwdTvE c=1 sm=1 tr=0 ts=63d9236b a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RvmDmJFTN0MA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=bD-wc-maA5_8PwMBU-AA:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=wE4qzEZ1AtK+eWhcZ3o2fJd+g5fjM+z6Xe7U/y8mg9Y=; b=jhHnkkLfck9fPRuOtlNrvez2xl Q2M45EYSNlkaatLmYex5N9Mr0yUt+vch1YT0RxBDWADvTDO67NYJ74a0fvV1DBaUnGec1hgGuOzAh IO/FBu057fc3dPziXARtx0i7F; Received: from 71-211-157-143.hlrn.qwest.net ([71.211.157.143]:35396 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pMrTn-003CX3-DC; Tue, 31 Jan 2023 07:19:23 -0700 From: Tom Tromey To: Simon Marchi via Gdb-patches Cc: Andrew Burgess , Simon Marchi , Simon Marchi Subject: Re: [PATCH v2] gdb/dwarf: dump cooked index contents in cooked_index_functions::dump References: <20230130160337.55890-1-simon.marchi@efficios.com> <87a61zvh7a.fsf@redhat.com> <03ff1644-df3d-2e6b-f2aa-49767abc580b@polymtl.ca> X-Attribution: Tom Date: Tue, 31 Jan 2023 07:19:20 -0700 In-Reply-To: <03ff1644-df3d-2e6b-f2aa-49767abc580b@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Mon, 30 Jan 2023 22:06:44 -0500") Message-ID: <87ilgmn5w7.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.157.143 X-Source-L: No X-Exim-ID: 1pMrTn-003CX3-DC X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-157-143.hlrn.qwest.net (murgatroyd) [71.211.157.143]:35396 X-Source-Auth: tom+tromey.com X-Email-Count: 1 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3021.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Simon" == Simon Marchi via Gdb-patches writes: Simon> See the patch below for a quick prototype. Simon> quick_symbol_functions::read_partial_symbols now returns a bool, and if Simon> it returns false (failure), objfile::require_partial_symbols removes Simon> that quick symbol instance from the qf list. I'm working to get rid of this lazy symbol stuff. So I'd rather not add another meaning to it. You can see the WIP on t/bg-dwarf-reading, but the basic idea is that instead of delaying the reading of DWARF, start the reading early and just delay the completion of it. I haven't sent this yet because it currently crashes, I think it will benefit from being rebased on the write-index-in-background patch. All the other methods in cooked_index_functions already do: dwarf2_per_objfile *per_objfile = get_dwarf2_per_objfile (objfile); if (per_objfile->per_bfd->index_table == nullptr) return; So maybe this would be an ok choice for dump. As an aside the code is doing: if (per_bfd->index_table == nullptr) return nullptr; cooked_index_vector *table = (gdb::checked_static_cast (per_bfd->index_table.get ())); It seems to me that it would be fine if checked_static_cast passed through null in this case -- that is, do not assert when the result is null if the parameter is also null. Tom