Re: [PATCH] Simplify interp::exec / interp_exec - let exceptions propagate

[Tom Tromey <tromey@adacore.com>]

>>>>> "Pedro" == Pedro Alves <pedro@palves.net> writes:

Pedro> This patch implements a simplication that I suggested here:
Pedro>   https://sourceware.org/pipermail/gdb-patches/2022-March/186320.html

Pedro> Currently, the interp::exec virtual method interface is such that
Pedro> subclass implementations must catch exceptions and then return them
Pedro> via normal function return.
...

Pedro> And, I can't see why we need to have interp_exec catch the exception
Pedro> and return it via the normal return path.  That's normally needed when
Pedro> we need to handle propagating exceptions across C code, like across
Pedro> readline or ncurses, but that's not the case here.

I think this is probably a leftover from the old libgdb idea.  I don't
really know much about it other than what I saw in comments, but I
gather the idea was to present a more ordinary C API, so return values
rather than longjmp exceptions.  Of course we gave up on that ages ago.

Pedro> It seems to me that we can simplify things by removing some
Pedro> try/catch-ing and just letting exceptions propagate normally.

Agreed.

Approved-By: Tom Tromey <tromey@adacore.com>

Tom