From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy3-pub.mail.unifiedlayer.com (gproxy3-pub.mail.unifiedlayer.com [69.89.30.42]) by sourceware.org (Postfix) with ESMTPS id 091A1385B50A for ; Fri, 27 Jan 2023 14:30:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 091A1385B50A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway5.mail.pro1.eigbox.com (Postfix) with ESMTP id 607F0100563CD for ; Fri, 27 Jan 2023 14:30:39 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id LPkVpDHTXc5SPLPkVppc9G; Fri, 27 Jan 2023 14:30:39 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=e7bD9Yl/ c=1 sm=1 tr=0 ts=63d3e00f a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=RvmDmJFTN0MA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=y26Bvzfj-3c2TpXgXE0A:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=EQYdtijbht3UPcv6PP5zOc8Qp8zYSkOursIrscrpIHk=; b=CPQytT6MxGQPy5bo1bqgGX9eu1 zt8opj4Lcvcfb9wD5Q3nkbL8hoHWpJ/cFWYk3d6NUgPnWPYxXrammXNhMPzuRq9yCBlHXw2uw8c/z VPkQGEb9GhNvJ3axQ04+DJzdT; Received: from 75-166-146-144.hlrn.qwest.net ([75.166.146.144]:43364 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pLPkT-002X9i-V7; Fri, 27 Jan 2023 07:30:39 -0700 From: Tom Tromey To: Andrew Burgess via Gdb-patches Cc: Simon Marchi , Tom Tromey , Andrew Burgess Subject: Re: [PATCH v2 4/4] Fix parameter-less template regression in new DWARF reader References: <20230110183338.2623088-1-tromey@adacore.com> <20230110183338.2623088-5-tromey@adacore.com> <871qnt2bob.fsf@tromey.com> <26ba8dcf-3f4e-983d-bbb8-a61c4b94c47d@simark.ca> <87wn58uvuu.fsf@redhat.com> X-Attribution: Tom Date: Fri, 27 Jan 2023 07:30:36 -0700 In-Reply-To: <87wn58uvuu.fsf@redhat.com> (Andrew Burgess via Gdb-patches's message of "Fri, 27 Jan 2023 10:15:21 +0000") Message-ID: <87ilgsqcc3.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 75.166.146.144 X-Source-L: No X-Exim-ID: 1pLPkT-002X9i-V7 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 75-166-146-144.hlrn.qwest.net (murgatroyd) [75.166.146.144]:43364 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3020.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: Sorry I haven't gotten back to fixing this. I've been pretty busy with a project at work, my other patches have all been rote stuff. Andrew> The underlying problem is that we use a different sort predicate for the Andrew> std::lower_bound and std::upper_bound calls (in some cases) than when we Andrew> sorted this list. I'm not sure this can ever work correctly. Yeah, that was my conclusion as well. My plan is to sort more naively again (writing our own strcasecmp though to avoid the performance thing on Windows), then have either the 'find' method or the caller in read.c do an extra filtering. Tom