From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-il1-x12b.google.com (mail-il1-x12b.google.com [IPv6:2607:f8b0:4864:20::12b]) by sourceware.org (Postfix) with ESMTPS id 3C4D23858C83 for ; Wed, 11 Jan 2023 17:30:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3C4D23858C83 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-il1-x12b.google.com with SMTP id bp26so8224439ilb.3 for ; Wed, 11 Jan 2023 09:30:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=+TppQICcoDm8YBJiBkk5cZd6BraASeAUeduEYQwiUjY=; b=lDbVpjav8618oBjirSxrEsDdZmMOs2p/psVIcW1Qe/m/wTxUWyYNeJozYAkgip4piy h/EHlp/bAouAj6MZuPgWD8rbaH8CdR10J2GV9iVQ6vLS2MtJIlxJWhiaAS3OEcH9UyUN XSB71hU30s31JqgyqFz8nvo6yI+xJ4E+FRS3YZKrNGXhn6++MyC7cyq1GrLJljF7TXoL ieLysC5zqe0VdLwTmp0xfcdbVXRcqfCZNftXiSSwW4jnyUMfAZKkitxaA7+Cd7+PoUHV 1DP8oDxKYLtWWk4Dv/x78NGJp1IigVE5H0yl9PALqbJC7XcG3wgkwuPojTpe+fTlR7H8 OQtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+TppQICcoDm8YBJiBkk5cZd6BraASeAUeduEYQwiUjY=; b=kfoNa1YFPDBzJoBTSxVKYm1tdiqOAuJVLVJafBeVPdJLd1diJOAogZJ3SjmZGqCyHZ TTr5CPf4Fi9USVf5w0QtBXdg0nOQs8UUFnsmjLttG8v9ZD7IvkHWxcLSOFj7kSDRF8Vm vw3wVRpa3vVJ62PdAY+Tx36P6Y0lX2AVyd5pfirZQzeD+W4fV3xAeDVWacwxNqQIyj87 jYRAKSCKUibpY7Q2WxFPakQ5pR2kFS/qigx8/e0x57cFDjY2AVIXbniU9eyFtWhKIEWd NMaoAS4N6ATcmAf/9W5B2P+lIpVynwGmKRfB4pvuwmeh61lmk4MwrMmTFJLedMjgyqGp VZxA== X-Gm-Message-State: AFqh2kogw10+djCiQ8C87Xfgwvm1URW6zoh3CqhsSOGe0eZxvTcyrZc5 0nGGazUS7jdDMmL7jhbdMap8CA== X-Google-Smtp-Source: AMrXdXv7xn8kUGtr9xGuBHmgqyPeySkJadj5/vOY5hpxIJD4IOoBAxYKNg/N1+aAYCyZkjWD/VcRwQ== X-Received: by 2002:a92:130d:0:b0:30d:8cef:9adb with SMTP id 13-20020a92130d000000b0030d8cef9adbmr2259193ilt.19.1673458232733; Wed, 11 Jan 2023 09:30:32 -0800 (PST) Received: from murgatroyd (97-122-76-186.hlrn.qwest.net. [97.122.76.186]) by smtp.gmail.com with ESMTPSA id c15-20020a02330f000000b0038a6ae38ceasm4830643jae.26.2023.01.11.09.30.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jan 2023 09:30:32 -0800 (PST) From: Tom Tromey To: Tom Tromey via Gdb-patches Cc: Tom Tromey , Joel Brobecker Subject: Re: [PATCH] Set _WIN32_WINNT in common.m4 configure check References: <20230109144716.1988567-1-tromey@adacore.com> X-Attribution: Tom Date: Wed, 11 Jan 2023 10:30:31 -0700 In-Reply-To: <20230109144716.1988567-1-tromey@adacore.com> (Tom Tromey via Gdb-patches's message of "Mon, 9 Jan 2023 07:47:16 -0700") Message-ID: <87ilhd6kso.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey via Gdb-patches writes: Tom> GCC recently added support for the Windows thread model, enabling Tom> libstdc++ to support Windows natively. However, this supporrt Tom> requires a version of Windows later than the minimum version that is Tom> supported by GDB. Tom> PR build/29966 points out that the GDB configure test for std::thread Tom> does not work in this situation, because _WIN32_WINNT is not defined Tom> in test program, and so seems to be fine. Tom> This patch is an attempt to fix the problem, by using the same setting Tom> for _WIN32_WINNT at configure time as is used at build time. Tom> I don't have access to one of the older systems so I don't think I can Tom> truly test this. I did do a mingw cross build, though. I'm going to Tom> ask the bug reporter to test it. There turns out to also be some small problem in libstdc++ so this patch can't fully be confirmed. However it also seems like an improvement, so I am going to check it in. Joel, I tend to think we should consider this for GDB 13. Without it, GDB 13 won't build with a newer GCC on some older Windows systems. Tom