From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 089773850B11 for ; Fri, 16 Dec 2022 13:31:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 089773850B11 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671197487; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pvcVvzcfI/xTAfTk5WuxtrolFOXzq/Vojh13LmVHDvI=; b=ZYZtD3PmvWJK6eFP+QLYIjmE27RuLXgHRfNHQ53ZfMEtblKfRU1R/JOvTksffIYZ2wUxe9 TMFWx2PgEDtVB0twVQtuvb6cwm5e2pQVNFRe1oxERVfaURuRz3jO4qHnxAE9zIgB2sHxMG FkToazCY1Dug/HI9JFHvHlBuS9b6NT4= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-645-_ntQt8OAMUaq3QRsGL1Mdw-1; Fri, 16 Dec 2022 08:31:24 -0500 X-MC-Unique: _ntQt8OAMUaq3QRsGL1Mdw-1 Received: by mail-wr1-f70.google.com with SMTP id r17-20020adfb1d1000000b002421ae7fd46so476318wra.10 for ; Fri, 16 Dec 2022 05:31:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pvcVvzcfI/xTAfTk5WuxtrolFOXzq/Vojh13LmVHDvI=; b=OsFk77sU4aNZdZ/Uvr0fGsuybGvnZnd6NaQcM87ZLrm8M1AvRHglpiVJ50o8/7E1bt RkVc/hf0xCHqCOnXnoWbN6etkgjm22apWuT5XlxaGs6xnUYQ/o7cjbgQWPQH8bij7X1b +bUwgV3QmFBHdLSXQhCOQXpYeWUQ+hVyTMk3ngSZ51pJRPvNiACXoDfeNvL35TrSV+ff XRQWw+heJ7mICRMAvyoP8IL6+x//6FHoMRk2Up/MwfpIRW6TgT0yELEMuMIuIjzpAw08 ez8GA1J+/2Pm/e35ZHq6zFrBiUH6Min0v1B1OtTBTHwRypiPMXdXEVtq0wYcDy7s9qWL PhnQ== X-Gm-Message-State: ANoB5pmonDGWkqsstsLe8bWLjIzXvs3SciTOUbyai4b4wF4q9+Lm0VSt /I01yv6/lqF26ZuTVdYhcZ2fRCpqkSnur9+FKMayoq/o32UKycp1d2f6pz8QsKquu64rcpLuntf R9FYkpkD86vU3miFdeEO8jQ== X-Received: by 2002:a05:600c:2042:b0:3d2:3ae8:885b with SMTP id p2-20020a05600c204200b003d23ae8885bmr8341471wmg.28.1671197483167; Fri, 16 Dec 2022 05:31:23 -0800 (PST) X-Google-Smtp-Source: AA0mqf7LTk1j2PIT8BxYvPA9Wp5Rvzlnd3RmroXmsJznS4EfDEbX4kdSmtlNvt25vuZeOUXr2ZXbFQ== X-Received: by 2002:a05:600c:2042:b0:3d2:3ae8:885b with SMTP id p2-20020a05600c204200b003d23ae8885bmr8341462wmg.28.1671197482997; Fri, 16 Dec 2022 05:31:22 -0800 (PST) Received: from localhost ([31.111.84.238]) by smtp.gmail.com with ESMTPSA id y24-20020a05600c341800b003d1de805de5sm2422770wmp.16.2022.12.16.05.31.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Dec 2022 05:31:22 -0800 (PST) From: Andrew Burgess To: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PUSHED] gdb: make more use of make_target_connection_string In-Reply-To: <680fe4f2-5ac4-37cc-dd64-3c38f0df9d2e@simark.ca> References: <53cf95c3389a3ecd97276d322e4a60fe3396a201.1671108652.git.aburgess@redhat.com> <2d9e0814-b4a8-fba8-9422-a1c746a15ebf@simark.ca> <87o7s4zjyq.fsf@redhat.com> <680fe4f2-5ac4-37cc-dd64-3c38f0df9d2e@simark.ca> Date: Fri, 16 Dec 2022 13:31:20 +0000 Message-ID: <87ilibzd93.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Simon Marchi writes: >> Normally I'd just push the fixes for this as obvious. But as that's >> what got me into this mess in the first place, I figure I should post >> the fixes here first :) > > Hehe :). The patch LGTM, you can add my: > > Approved-By: Simon Marchi > Thanks, pushed. Andrew