From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 21A7E395A44D for ; Tue, 31 May 2022 16:14:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 21A7E395A44D Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-159-psAbO4l9N5-II9sU9A3zVg-1; Tue, 31 May 2022 12:14:31 -0400 X-MC-Unique: psAbO4l9N5-II9sU9A3zVg-1 Received: by mail-wm1-f72.google.com with SMTP id m26-20020a05600c3b1a00b00397220d6329so1530624wms.5 for ; Tue, 31 May 2022 09:14:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=UvsagCxBgfuf5OMxOH/K5/PUS4H46iJ8q4uN8LWbb7I=; b=X8X0mnEvx3yFFju78VTllpDjapEzbRYEAsdrCW9JgFqJlSdyrCHYeOpff8JRZPrk0Y MsrI7/tHm9oik0rlMtHkEhkiIUPLdBik970gmwDfoRSuJH9LLswXYK4LdxXDDnUshV1A kL1q4vmjtaEMLbhXco6/KIDUJO9bn6q/zX7UbUf9dnDLZiTJ6uXya1S6hprCGGG1K3qX jdm/yZcQ3wr3PEmBln78ANoBAg6vg/GRhBkCyBMeF0frM0pjw5ffPRKb0sraNr1+eRFk Q3NTW2VkVKjwiDHAiGYVEYRoFD1av7gZBvDZNDdPC6CKbm0Gh1cUWtgO+tAR1imlj19D BOrQ== X-Gm-Message-State: AOAM531PBRCRHJ9ZnVejtucg/yZV0rnZlI7YnroTaCAtMs0SeWLH6i3B ebBUQXr8rQtxZaM1WFdKAzR1KbCltf3GK3e3CTtzFVueUs8CINY2EVY9qlfi+kWILxCGBfqx2t3 PfGr80FevQ0F20eXb7vLAhg== X-Received: by 2002:adf:e48a:0:b0:210:3038:6916 with SMTP id i10-20020adfe48a000000b0021030386916mr10392812wrm.561.1654013669853; Tue, 31 May 2022 09:14:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy9RCG+zdmrh4wSzzbMDoIwj6jFwiMDwgS6JjzBy9/DlGViNfXbGSnN2q4OxDqxjtpTkhOqQQ== X-Received: by 2002:adf:e48a:0:b0:210:3038:6916 with SMTP id i10-20020adfe48a000000b0021030386916mr10392795wrm.561.1654013669598; Tue, 31 May 2022 09:14:29 -0700 (PDT) Received: from localhost (host109-152-215-36.range109-152.btcentralplus.com. [109.152.215.36]) by smtp.gmail.com with ESMTPSA id i7-20020a5d5847000000b002101ed6e70fsm11324966wrf.37.2022.05.31.09.14.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 May 2022 09:14:29 -0700 (PDT) From: Andrew Burgess To: Nils-Christian Kempke , gdb-patches@sourceware.org Cc: JiniSusan.George@amd.com Subject: Re: [PATCH v2 00/16] Fortran compiler identification and ifx testsuite support In-Reply-To: <20220531092423.2361679-1-nils-christian.kempke@intel.com> References: <20220531092423.2361679-1-nils-christian.kempke@intel.com> Date: Tue, 31 May 2022 17:14:27 +0100 Message-ID: <87ilpld6ho.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 May 2022 16:14:34 -0000 Nils-Christian Kempke via Gdb-patches writes: > Hi, > > V1 of this series can be found here: > > https://sourceware.org/pipermail/gdb-patches/2022-May/188904.html > > Changes since v1: > > * Patch 03: There were some leftovers in the commit message from an > earlier version of the patch - these have been removed. > > * Patch 04: The commit message has been renamed and a comment been > adapted according to Andrew's feedback. The getting_compiler_info > variable now also uses actual bool values. > > * Patch 06: The commit message has been adapted and now says that > the intel C compiler names have not yet been used in the testsuite (to > avoid confusion as to why there are no changes done in the testsuite). > > * Patch 08: This patch has been dropped, instead an ifx bug was filed. > So from now on the patch numbers will be off by 1. > > * Patch 11 (now 10): The comment has been reworded and > 'need the -debug-parameters all flag set to emit' > now reads > 'need the -debug-parameters flag set to emit' > Also, not only ifx but also ifort requires the flag so it is now added > for both compilers. > > * Patch 13 (now 12): I added a comment to the patch as well as made > the commit message a lot more elaborate (after some online > discussion). > > * Patch 14: This patch has been dropped for now as we are claifying > whether ifx should change its debug output. The patch numbers will > now be off by 2. > > * Patch 18 (now 16): The '-wrap' is now used here instead of adding > the $gdb_prompt in test_multiple. Also, flang was added to the > comments. > > Patch 01, 02, 05, 07, 09 (now 08), 10 (now 09), 12 (now 11), 15 (now 13), > 16 (now 14), and 17 (now 15) had been approved before and were not > changed/included here. I've approved all these patches now. For me I would have preferred to see the complete set of patches included each time the series is reposted, it makes it easier to apply the patches. Though I do also appreciate you commenting about which patches have changed, and what the changes were. Thanks, Andrew > > I am happy about any feedback. > > Cheers, > > Nils > > Abdul Basit Ijaz (1): > gdb/testsuite: Use -module option for Intel Fortran compilers > > Cristian Sandu (1): > gdb/testsuite: add Fortran compiler identification to GDB > > Felix Willgerodt (1): > gdb/testsuite: Fix fortran types for Intel compilers. > > Nils-Christian Kempke (13): > gdb/testsuite: remove F77_FOR_TARGET support > gdb/testsuite: move getting_compiler_info to front of gdb_compile > gdb/testsuite: rename intel next gen c/cpp compilers > gdb/testsuite: disable charset.exp for intel compilers > testsuite, fortran: add required external keyword > testsuite, fortran: add compiler dependent types to > dynamic-ptype-whatis > testsuite, fortran: Add '-debug-parameters all' when using ifx/ifort > testsuite/lib: add check_optional_entry for GDBInfoSymbols > testsuite, fortran: fix info-types for intel compilers > testsuite, fortran: allow additional completions in module.exp > gdb, testsuite, fortran: fix double free in mixed-lang-stack.exp > gdb, testsuite, fortran: fixup mixed-lang-stack for Intel/LLVM > compilers > gdb/testsuite: fixup common-block.exp for intel compilers > > gdb/testsuite/boards/cc-with-tweaks.exp | 5 - > gdb/testsuite/boards/debug-types.exp | 1 - > gdb/testsuite/boards/gold-gdb-index.exp | 1 - > gdb/testsuite/gdb.fortran/assumedrank.exp | 6 +- > gdb/testsuite/gdb.fortran/charset.exp | 5 + > .../gdb.fortran/class-allocatable-array.exp | 4 +- > gdb/testsuite/gdb.fortran/common-block.exp | 38 ++++++- > .../gdb.fortran/derived-type-striding.exp | 2 +- > .../gdb.fortran/dynamic-ptype-whatis.exp | 79 +++++++------- > gdb/testsuite/gdb.fortran/function-calls.f90 | 1 + > gdb/testsuite/gdb.fortran/info-types.exp | 20 +++- > gdb/testsuite/gdb.fortran/library-module.exp | 2 +- > .../gdb.fortran/mixed-lang-stack.cpp | 12 +-- > .../gdb.fortran/mixed-lang-stack.exp | 21 ++-- > gdb/testsuite/gdb.fortran/module.exp | 5 +- > gdb/testsuite/gdb.fortran/namelist.exp | 2 +- > gdb/testsuite/gdb.fortran/nested-funcs-2.exp | 3 +- > .../gdb.fortran/ptype-on-functions.exp | 6 +- > gdb/testsuite/gdb.fortran/vla-type.exp | 2 +- > gdb/testsuite/lib/compiler.F90 | 69 ++++++++++++ > gdb/testsuite/lib/compiler.c | 2 +- > gdb/testsuite/lib/compiler.cc | 2 +- > gdb/testsuite/lib/fortran.exp | 100 +++++++++++------- > gdb/testsuite/lib/future.exp | 21 +--- > gdb/testsuite/lib/gdb.exp | 62 +++++++---- > gdb/testsuite/lib/sym-info-cmds.exp | 18 +++- > 26 files changed, 318 insertions(+), 171 deletions(-) > create mode 100644 gdb/testsuite/lib/compiler.F90 > > -- > 2.25.1 > > Intel Deutschland GmbH > Registered Address: Am Campeon 10, 85579 Neubiberg, Germany > Tel: +49 89 99 8853-0, www.intel.de > Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva > Chairperson of the Supervisory Board: Nicole Lau > Registered Office: Munich > Commercial Register: Amtsgericht Muenchen HRB 186928