From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt-proxy28.mail.unifiedlayer.com (alt-proxy28.mail.unifiedlayer.com [74.220.216.123]) by sourceware.org (Postfix) with ESMTPS id 0D70F383821C for ; Thu, 26 May 2022 17:43:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0D70F383821C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw14.mail.unifiedlayer.com (unknown [10.0.90.129]) by progateway1.mail.pro1.eigbox.com (Postfix) with ESMTP id 2576C10040422 for ; Thu, 26 May 2022 17:43:39 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id uHWMnyaz0hWk0uHWNndVNG; Thu, 26 May 2022 17:43:39 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=IrfbzJzg c=1 sm=1 tr=0 ts=628fbc4b a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=oZkIemNP1mAA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=CCpqsmhAAAAA:8 a=-LtdiedP9xGp3kwdCl8A:9 a=ul9cdbp4aOFLsgKbc677:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=11yRmZMSaob1ww0uFWlgqtNLMi8qLTwsB/jsulV+t70=; b=pnuQWJMCZhMdpePCc0b2IsCs1Q xYs44Z4+EYh4cig2PwsxFRw3kuCUGX7PlHLyAl8zHobrzdTWW+zsuY/jamXvhSdXH+DKyCI7ihheg WA8ieIt8qiFgUxKZ3B3TzvQ79; Received: from 71-211-158-194.hlrn.qwest.net ([71.211.158.194]:55850 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nuHWM-002j5k-I1; Thu, 26 May 2022 11:43:38 -0600 From: Tom Tromey To: Andrew Burgess via Gdb-patches Cc: Andrew Burgess Subject: Re: [PATCH 1/2] gdb: use gdb::unique_xmalloc_ptr for docs in cmdpy_init References: <31151a0451266a6dd2a4c01e4a60795596ad2077.1652784658.git.aburgess@redhat.com> X-Attribution: Tom Date: Thu, 26 May 2022 11:43:37 -0600 In-Reply-To: <31151a0451266a6dd2a4c01e4a60795596ad2077.1652784658.git.aburgess@redhat.com> (Andrew Burgess via Gdb-patches's message of "Tue, 17 May 2022 11:51:44 +0100") Message-ID: <87ilps6vg6.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.158.194 X-Source-L: No X-Exim-ID: 1nuHWM-002j5k-I1 X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-158-194.hlrn.qwest.net (murgatroyd) [71.211.158.194]:55850 X-Source-Auth: tom+tromey.com X-Email-Count: 9 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3023.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 May 2022 17:43:41 -0000 >>>>> "Andrew" == Andrew Burgess via Gdb-patches writes: Andrew> Make use of gdb::unique_xmalloc_ptr to hold the documentation Andrew> string in cmdpy_init (when creating a custom GDB command in Python). Andrew> I think this is all pretty straight forward, the only slight weirdness Andrew> is the removal of the call to free toward the end of this function. Andrew> Prior to this commit, if an exception was thrown after the GDB command Andrew> was created then we would (I think) end up freeing the documentation Andrew> string even though the command would remain registered with GDB, which Andrew> would surely lead to undefined behaviour. Andrew> After this commit we release the doc string at the point that we hand Andrew> it over to the command creation routines. If we throw _after_ the Andrew> command has been created within GDB then the doc string will be left Andrew> live. If we throw during the command creation itself (either from Andrew> add_prefix_cmd or add_cmd) then it is up to those functions to free Andrew> the doc string (I suspect we don't, but I think in general the Andrew> commands are pretty bad at cleaning up after themselves, so I don't Andrew> think this is a huge problem). This looks ok to me. Maybe an add_prefix_cmd overload that takes a unique_xmalloc_ptr would be the way to go eventually. Tom