public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Lancelot SIX via Gdb-patches <gdb-patches@sourceware.org>
Cc: Lancelot SIX <lancelot.six@amd.com>,  lsix@lancelotsix.com
Subject: Re: [PATCH] gdb: cooked_index_functions::expand_symtabs_matching: require psymtab
Date: Wed, 18 May 2022 14:09:49 -0600	[thread overview]
Message-ID: <87ilq2d2lu.fsf@tromey.com> (raw)
In-Reply-To: <20220426141917.2887797-1-lancelot.six@amd.com> (Lancelot SIX via Gdb-patches's message of "Tue, 26 Apr 2022 15:19:17 +0100")

>>>>> Lancelot SIX via Gdb-patches <gdb-patches@sourceware.org> writes:

> diff --git a/gdb/dwarf2/read.c b/gdb/dwarf2/read.c
> index 37e9587e43e..489b857459b 100644
> --- a/gdb/dwarf2/read.c
> +++ b/gdb/dwarf2/read.c
> @@ -18559,6 +18559,9 @@ cooked_index_functions::expand_symtabs_matching
>        domain_enum domain,
>        enum search_domain kind)
>  {
> +  /* Make sure that the psymtab have been read for objfile.  */
> +  objfile->require_partial_symbols (false);

Why 'false' here, when psymtab.c uses 'true'?

Also, can this bug affect the other methods in cooked_index_functions?

thanks,
Tom

  parent reply	other threads:[~2022-05-18 20:09 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-26 14:19 Lancelot SIX
2022-04-26 19:28 ` Tom Tromey
2022-04-26 23:44   ` Lancelot SIX
2022-04-27 14:11     ` Lancelot SIX
2022-05-04 17:11   ` Six, Lancelot
2022-05-17 13:54     ` Pedro Alves
2022-05-18 20:09 ` Tom Tromey [this message]
2022-05-19 10:46   ` Lancelot SIX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ilq2d2lu.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=lancelot.six@amd.com \
    --cc=lsix@lancelotsix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).