From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gproxy4-pub.mail.unifiedlayer.com (gproxy4-pub.mail.unifiedlayer.com [69.89.23.142]) by sourceware.org (Postfix) with ESMTPS id 8B4BD3857C71 for ; Thu, 7 Apr 2022 15:32:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8B4BD3857C71 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw12.mail.unifiedlayer.com (unknown [10.0.90.127]) by progateway6.mail.pro1.eigbox.com (Postfix) with ESMTP id BAF3210047A7B for ; Thu, 7 Apr 2022 15:32:22 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id cU7Sn7TGnb2WGcU7SnR77O; Thu, 07 Apr 2022 15:32:22 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=JN7+D+Gb c=1 sm=1 tr=0 ts=624f0406 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=z0gMJWrwH1QA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=WGg__ZBKAAAA:8 a=K9ODkmCKaSLqwP2Jp8QA:9 a=vwV2fA3wUQyfisxp2d0v:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=7U5KK/rk/DickNc3d02sdolH/XD+ZscgY+7tVG/3tTU=; b=AC/jrKLAI04C2ijXb0oLPDZ9GQ eKDaO7xCbHT33YQCjLvXeHDqQ5klTSeRuci/bNAwPiS4Dt/SPBCQsp0+hkJmob2dtHewOx0tBuhWv wtqYOy76Eti9K5UwMaoou/+nv; Received: from 71-211-154-204.hlrn.qwest.net ([71.211.154.204]:55484 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ncU7S-002efo-0K; Thu, 07 Apr 2022 09:32:22 -0600 From: Tom Tromey To: Jiangshuai Li Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb:csky add support target-descriptions for CSKY arch References: <20220328020338.2360-1-jiangshuai_li@c-sky.com> X-Attribution: Tom Date: Thu, 07 Apr 2022 09:32:21 -0600 In-Reply-To: <20220328020338.2360-1-jiangshuai_li@c-sky.com> (Jiangshuai Li's message of "Mon, 28 Mar 2022 10:03:38 +0800") Message-ID: <87ilrkaoze.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.154.204 X-Source-L: No X-Exim-ID: 1ncU7S-002efo-0K X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-154-204.hlrn.qwest.net (murgatroyd) [71.211.154.204]:55484 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3029.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, GIT_PATCH_0, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Apr 2022 15:32:25 -0000 >>>>> Jiangshuai Li writes: Thank you for the patch. I don't know anything about csky and so I can't really review any of the architecture details. I'll just take your word for that. > diff --git a/gdb/csky-tdep.c b/gdb/csky-tdep.c > index 04f558cf14b..447baa1ed58 100644 > --- a/gdb/csky-tdep.c > +++ b/gdb/csky-tdep.c > @@ -67,6 +67,424 @@ static struct reggroup *vr_reggroup; > static struct reggroup *mmu_reggroup; > static struct reggroup *prof_reggroup; > +static char *csky_supported_tdesc_feature_names[] = { > + (char *)"org.gnu.csky.abiv2.gpr", I think the casts here are a red flag, you ought to make the array use "const char *". > +struct csky_supported_tdesc_register > +{ > + char name[16]; I think "const char *" here is probably better as well, just because it's more idiomatic. > +/* Get csky supported registers's count for tdesc xml. */ > +static int > +csky_get_supported_tdesc_registers_count() > +{ > + int count = 0; > + int size = sizeof (struct csky_supported_tdesc_register); > + count += sizeof (csky_supported_gpr_regs)/size; > + count += sizeof (csky_supported_fpu_regs)/size; I suggest using the ARRAY_SIZE macro instead. > +/* Return a supported register according to index. */ > +static struct csky_supported_tdesc_register * > +csky_get_supported_register_by_index (int index) > +{ > + static struct csky_supported_tdesc_register tdesc_reg; > + int count = 0; > + int multi, remain; > + int size = sizeof (struct csky_supported_tdesc_register); > + int count_gpr = sizeof (csky_supported_gpr_regs)/size; Here too. > +/* Check whether xml has discribled the essential regs. */ Typo, "described". Tom