From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from outbound-ss-820.bluehost.com (outbound-ss-820.bluehost.com [69.89.24.241]) by sourceware.org (Postfix) with ESMTPS id D17FA3889811 for ; Fri, 18 Mar 2022 16:58:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D17FA3889811 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com Received: from cmgw11.mail.unifiedlayer.com (unknown [10.0.90.126]) by progateway2.mail.pro1.eigbox.com (Postfix) with ESMTP id 369861004BB74 for ; Fri, 18 Mar 2022 16:58:46 +0000 (UTC) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTP id VFw5nxaJhwm8iVFw5nzARX; Fri, 18 Mar 2022 16:58:46 +0000 X-Authority-Reason: nr=8 X-Authority-Analysis: v=2.4 cv=DpSTREz+ c=1 sm=1 tr=0 ts=6234ba46 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=o8Y5sQTvuykA:10:nop_rcvd_month_year a=Qbun_eYptAEA:10:endurance_base64_authed_username_1 a=HtrDkaladwm8gKTL68gA:9 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=6q5jyIyLEGnKuktVjDF3jem4W7DMF7qN3Ce0mEsWFvM=; b=f4Ah97M6Z+AmX3Vz4MY8hy3aoF DPBeWa2JgVkx87juGWREV2POzu3JQEJr7g3Z84ipFbeh9r4+UwHaJJBVcXJxWLiBBcbXrIs5dQnyN V8QE/M6L6REfPigkkot2mlGoB; Received: from 71-211-175-224.hlrn.qwest.net ([71.211.175.224]:43164 helo=prentzel) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nVFw5-000UKs-Az; Fri, 18 Mar 2022 10:58:45 -0600 From: Tom Tromey To: Pedro Alves Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH] Add Rust parser check for end of expression References: <20220318044450.221851-1-tom@tromey.com> <1cd1981e-658e-dd2f-1ab7-e696dd7ef2ff@palves.net> X-Attribution: Tom Date: Fri, 18 Mar 2022 10:58:44 -0600 In-Reply-To: <1cd1981e-658e-dd2f-1ab7-e696dd7ef2ff@palves.net> (Pedro Alves's message of "Fri, 18 Mar 2022 16:00:31 +0000") Message-ID: <87ilsbfb97.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.175.224 X-Source-L: No X-Exim-ID: 1nVFw5-000UKs-Az X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-175-224.hlrn.qwest.net (prentzel) [71.211.175.224]:43164 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3024.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Mar 2022 16:58:47 -0000 >> I noticed that "print 5," passed in Rust -- the parser wasn't checking >> that the entire input was used. This patch fixes the problem. This >> in turn pointed out another bug in the parser, namely that it didn't >> lex the next token after handling a string token. This is also fixed >> here. Pedro> OOC, is the lex-next-token bug something that is also covered by Pedro> the added test? It doesn't seem to use strings. Yes, if you remove that hunk there will be other regressions. Tom