From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id DCEE33949F26 for ; Wed, 23 Feb 2022 14:21:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DCEE33949F26 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-445-D4OOlwWcNByl_2VZfeoDAw-1; Wed, 23 Feb 2022 09:21:01 -0500 X-MC-Unique: D4OOlwWcNByl_2VZfeoDAw-1 Received: by mail-wm1-f72.google.com with SMTP id 10-20020a1c020a000000b0037fae68fcc2so1184466wmc.8 for ; Wed, 23 Feb 2022 06:21:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=VbjoJw/YXbguccewwjHVjsZRmyBFrp5+XlB4e4wkHWA=; b=aN78Cx7A7CBnEVpSfyniNgrjEcbXwrvoAvVF3YCm+aCcLEh0fTttHar+mm482D5waP qIODbsOV7hJizxBec9XTOLPxn5EdXostE2GcjNhDwrfnlQ4RlUeTj3tnrF7yqp+q0ZK7 FDgtaudWNdp3mFZxB5HFpc8qMKvFC+5LUMu2C4jxqKOEFyKEwkNu90qzc1P8/iY88kMC iKJh/eoz6hjadreqbvLL1iVdWNMOVpS3EZLGYb4Agu3KnVLlB5A7DuuDTX5l6ZdfQxUF 4VTohCDCeOHZfWvxNNp1KOcJGIAULqN/yAXLlHNI4WNS3BXvghNer6MRQ7Q6Ve9jfK8n OJUQ== X-Gm-Message-State: AOAM532s3uavXE8ChP1JnxtW+7hTHKODkr1drrryTdmAgwvp635dTyxy MzBx68HHl8GVbeupUhYQPAe9/+jPd0i9S9sVq5XVMDJtVTW3xKA/LxuwpvefHyGEajIS6TguNIM 4oz2RUuvN6ZwWt7eY/oaWWnOCu/uuQPZV2XDwIpohi3t5SRbCmkIf89j1XMFcZ75CrJKGgtt+zg == X-Received: by 2002:a05:600c:190d:b0:351:4a49:4bda with SMTP id j13-20020a05600c190d00b003514a494bdamr7621987wmq.194.1645626059920; Wed, 23 Feb 2022 06:20:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJyW9q8zE5Etrp+Vu6AD7lihVlTHQ/r8My7qWMZbsk2NCpwLeg02USFMCK0mkdxnVa83ueF1dA== X-Received: by 2002:a05:600c:190d:b0:351:4a49:4bda with SMTP id j13-20020a05600c190d00b003514a494bdamr7621964wmq.194.1645626059596; Wed, 23 Feb 2022 06:20:59 -0800 (PST) Received: from localhost (host86-169-131-29.range86-169.btcentralplus.com. [86.169.131.29]) by smtp.gmail.com with ESMTPSA id w18sm39127596wrl.62.2022.02.23.06.20.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Feb 2022 06:20:58 -0800 (PST) From: Andrew Burgess To: gdb-patches@sourceware.org Cc: Subject: Re: [PATCH] gdb/python: add gdb.Architecture.format_address In-Reply-To: <83ilt7t0s1.fsf@gnu.org> References: <20220211161721.3252422-1-aburgess@redhat.com> <83leyhs07f.fsf@gnu.org> <878ru4cepy.fsf@redhat.com> <837d9oumhd.fsf@gnu.org> <87sfsbattq.fsf@redhat.com> <83ilt7t0s1.fsf@gnu.org> Date: Wed, 23 Feb 2022 14:20:57 +0000 Message-ID: <87ilt5br5i.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Feb 2022 14:21:05 -0000 Eli Zaretskii via Gdb-patches writes: >> From: Andrew Burgess >> Cc: gdb-patches@sourceware.org >> Date: Tue, 22 Feb 2022 13:56:17 +0000 >> >> So, appologies, but this is another complete rewrite of the docs. With >> the exception of the name, for which I still have no better suggestions, >> how's this? > > Let's see... > >> +@defun Architecture.format_address (@var{address}) >> +Return a string in the format @samp{@var{addr} >> +<@var{symbol}+@var{offset}>}, where @var{addr} is @var{address} >> +formatted in hexadecimal, @var{symbol} is the closest earlier symbol >> +to @var{address}, and @var{offset} is the offset from @var{symbol} to >> +@var{address} in decimal. > > I think instead of "closest earlier" it would be best to say > > ... @var{symbol} is the symbol whose address is the nearest to > @var{address} and below it in memory ... > > Other than that, SGTM, thanks. Thanks for all your feedback. I've made this change locally, and it will be included once someone has reviewed the rest of the code. Thanks, Andrew