From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway24.websitewelcome.com (gateway24.websitewelcome.com [192.185.51.228]) by sourceware.org (Postfix) with ESMTPS id 069BB3858412 for ; Wed, 24 Nov 2021 15:53:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 069BB3858412 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm13.websitewelcome.com (cm13.websitewelcome.com [100.42.49.6]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 75AA43685 for ; Wed, 24 Nov 2021 09:53:29 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id puaPmvYGUHrvkpuaPmgma6; Wed, 24 Nov 2021 09:53:29 -0600 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=JSCvMHL8JuXq5e4F3jQj48IiO/29pKqwrwokzAC2TUw=; b=vb9XiU6nB/haWk7R8tE7buAAFg +QiY7fqpecpsNX1ELExj8n++QklQwGQuoEiGshPI7UDNFP/Hoo3dP75VVL+beGAZ72jJLylTJNnCT ffCrXse1lQ1FfQW/7zYvAoTIB; Received: from 97-122-68-246.hlrn.qwest.net ([97.122.68.246]:40420 helo=localhost.localdomain) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mpuaP-0014iF-3K; Wed, 24 Nov 2021 08:53:29 -0700 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH v2 04/32] Refactor dwarf2_get_pc_bounds References: <20211104180907.2360627-1-tom@tromey.com> <20211104180907.2360627-5-tom@tromey.com> <9efe554c-69e7-1904-91d7-503a390b0bfb@simark.ca> X-Attribution: Tom Date: Wed, 24 Nov 2021 08:53:28 -0700 In-Reply-To: <9efe554c-69e7-1904-91d7-503a390b0bfb@simark.ca> (Simon Marchi's message of "Fri, 5 Nov 2021 15:51:10 -0400") Message-ID: <87ilwhwnwn.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.68.246 X-Source-L: No X-Exim-ID: 1mpuaP-0014iF-3K X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-68-246.hlrn.qwest.net (localhost.localdomain) [97.122.68.246]:40420 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3025.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Nov 2021 15:53:31 -0000 >>>>> "Simon" == Simon Marchi writes: >> @@ -14036,10 +14044,9 @@ dwarf2_ranges_process (unsigned offset, struct dwarf2_cu *cu, dwarf_tag tag, >> static int >> dwarf2_ranges_read (unsigned offset, CORE_ADDR *low_return, >> CORE_ADDR *high_return, struct dwarf2_cu *cu, >> - dwarf2_psymtab *ranges_pst, dwarf_tag tag) >> + addrmap *map, void *datum, dwarf_tag tag) Simon> Perhaps it's code that is going to be deleted anyway, but the comment Simon> above this would need to be updated. I did this, thanks. Tom