public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] gdb fix PowerPC test gdb.arch/ppc-longdouble.exp
@ 2021-11-18  0:12 Carl Love
  2021-11-18 15:22 ` Tom Tromey
  0 siblings, 1 reply; 2+ messages in thread
From: Carl Love @ 2021-11-18  0:12 UTC (permalink / raw)
  To: gdb-patches; +Cc: cel, Will Schmidt, Rogerio Alves

GDB maintainers:

The following patch fixes warnings of duplicate tests as described in
the commit log.

Please let me know if this patch is acceptable for mainline.

                   Carl 

----------------------------------------------------
gdb fix PowerPC test gdb.arch/ppc-longdouble.exp

The test complains of duplicate tests.

DUPLICATE: gdb.arch/ppc-longdouble.exp: continue to breakpoint: return

The do_test calls gdb_continue_to_breakpoint "return".  The duplicates
are the result of calling do_test three times with different arguments.

This patch fixes the duplicate tests by adding $name to the
gdb_continue_to_breakpoint argument.

Patch tested on Power 10  ppc64le GNU/Linux, no duplicate tests reported,
no new regression errors.
---
 gdb/testsuite/gdb.arch/ppc-longdouble.exp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/testsuite/gdb.arch/ppc-longdouble.exp b/gdb/testsuite/gdb.arch/ppc-longdouble.exp
index 6e3b1bda542..2a49e456a68 100644
--- a/gdb/testsuite/gdb.arch/ppc-longdouble.exp
+++ b/gdb/testsuite/gdb.arch/ppc-longdouble.exp
@@ -39,7 +39,7 @@ proc do_test { name {opts {}} } {
 
     # Run to the breakpoint at return.
     gdb_breakpoint [gdb_get_line_number "return"]
-    gdb_continue_to_breakpoint "return"
+    gdb_continue_to_breakpoint "return test: $name"
 
     # Print the value of ld
     gdb_test "print ld" ".* = 1\\.375.*" "the value of ld is 1.375 ($name)"
-- 
2.30.2



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] gdb fix PowerPC test gdb.arch/ppc-longdouble.exp
  2021-11-18  0:12 [PATCH] gdb fix PowerPC test gdb.arch/ppc-longdouble.exp Carl Love
@ 2021-11-18 15:22 ` Tom Tromey
  0 siblings, 0 replies; 2+ messages in thread
From: Tom Tromey @ 2021-11-18 15:22 UTC (permalink / raw)
  To: Carl Love via Gdb-patches; +Cc: Carl Love, Rogerio Alves

>>>>> "Carl" == Carl Love via Gdb-patches <gdb-patches@sourceware.org> writes:

Carl> The following patch fixes warnings of duplicate tests as described in
Carl> the commit log.

Carl> Please let me know if this patch is acceptable for mainline.

Thank you for the patch.  This looks good to me.

Tom

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-11-18 15:22 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-18  0:12 [PATCH] gdb fix PowerPC test gdb.arch/ppc-longdouble.exp Carl Love
2021-11-18 15:22 ` Tom Tromey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).