From: Tom Tromey <tom@tromey.com>
To: Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/3] gdb: avoid dereferencing empty str_offsets_base optional in dwarf_decode_macros
Date: Wed, 04 Aug 2021 10:03:52 -0600 [thread overview]
Message-ID: <87im0l5h93.fsf@tromey.com> (raw)
In-Reply-To: <20210803153114.2516992-2-simon.marchi@polymtl.ca> (Simon Marchi via Gdb-patches's message of "Tue, 3 Aug 2021 11:31:13 -0400")
>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
Simon> Fix that by propagating down a gdb::optional<ULONGEST> for the str
Simon> offsets base instead of ULONGEST. [...]
Looks good. Thank you.
Tom
next prev parent reply other threads:[~2021-08-04 16:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 18:42 [PATCH] gdbsupport: add debug assertions in gdb::optional::get Simon Marchi
2021-08-02 17:19 ` Tom Tromey
2021-08-03 12:56 ` Simon Marchi
2021-08-03 13:14 ` Simon Marchi
2021-08-03 15:31 ` [PATCH 1/3] gdb: fix typo in complaint in dwarf2/macro.c Simon Marchi
2021-08-03 15:31 ` [PATCH 2/3] gdb: avoid dereferencing empty str_offsets_base optional in dwarf_decode_macros Simon Marchi
2021-08-04 16:03 ` Tom Tromey [this message]
2021-08-03 15:31 ` [PATCH 3/3] gdb/testsuite: fix gdb.base/info-macros.exp with clang Simon Marchi
2021-08-04 16:15 ` Tom Tromey
2021-08-04 19:39 ` Simon Marchi
2021-08-04 15:52 ` [PATCH 1/3] gdb: fix typo in complaint in dwarf2/macro.c Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87im0l5h93.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).