From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway31.websitewelcome.com (gateway31.websitewelcome.com [192.185.143.33]) by sourceware.org (Postfix) with ESMTPS id 8C50D385E838 for ; Thu, 29 Jul 2021 17:43:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8C50D385E838 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tromey.com Received: from cm12.websitewelcome.com (cm12.websitewelcome.com [100.42.49.8]) by gateway31.websitewelcome.com (Postfix) with ESMTP id 0B44D1E7176 for ; Thu, 29 Jul 2021 12:43:04 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 9A1nmMWhSsCiy9A1nm1HYl; Thu, 29 Jul 2021 12:41:03 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=2QjfljtSXrYyu7akmo+Z8OOTEPQlJBr2msDnMmQtUn8=; b=V4hgb9OQh/gWAL/KvawZneLxvf blmlt9BZ+ek2mWrO1pIW6WImDYDF/9R0Wi53Swk8sC8fRh1lpP3+/9bZC3xXhZW/EEplkZY0Rxk7J GJ9qlb/NreCiFaz5f/WGkhMtY; Received: from 97-122-74-117.hlrn.qwest.net ([97.122.74.117]:44460 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1m9A1n-001660-IK; Thu, 29 Jul 2021 11:41:03 -0600 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , Simon Marchi via Gdb-patches Subject: Re: [PATCH 15/16] gdb: make cmd_list_element var an optional union References: <20210714045520.1623120-1-simon.marchi@polymtl.ca> <20210714045520.1623120-16-simon.marchi@polymtl.ca> <87wnpacjaf.fsf@tromey.com> X-Attribution: Tom Date: Thu, 29 Jul 2021 11:41:02 -0600 In-Reply-To: (Simon Marchi's message of "Wed, 28 Jul 2021 16:59:47 -0400") Message-ID: <87im0tauhd.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.74.117 X-Source-L: No X-Exim-ID: 1m9A1n-001660-IK X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-74-117.hlrn.qwest.net (murgatroyd) [97.122.74.117]:44460 X-Source-Auth: tom+tromey.com X-Email-Count: 16 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3023.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, RCVD_IN_SBL_CSS, SPF_HELO_PASS, SPF_NEUTRAL, TXREP, URIBL_CSS_A autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Jul 2021 17:43:07 -0000 >>>>> "Simon" == Simon Marchi writes: Simon> I'd like to add that to our gdb::optional version (maybe predicated on Simon> _GLIBCXX_DEBUG would be fine)? But I wonder why the one from libstdc++ Simon> doesn't already have it... It might be there, at least along some paths: constexpr _Tp& _M_get() noexcept { __glibcxx_assert(this->_M_is_engaged()); return static_cast<_Dp*>(this)->_M_payload._M_get(); } There are other implementations of this method that don't check, though, and I don't understand why. Anyway I think it would be fine to add. Tom