From: Tom Tromey <tromey@adacore.com>
To: Christian Biesinger <cbiesinger@google.com>
Cc: Tom Tromey <tromey@adacore.com>,
gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 2/2] Decode Ada types in Python layer
Date: Fri, 18 Jun 2021 09:09:29 -0600 [thread overview]
Message-ID: <87im2bus46.fsf@tromey.com> (raw)
In-Reply-To: <CAPTJ0XH=bbNaaxqhUQn4zcvjrdd1WOowf6uif8efQ2rwx+ocMQ@mail.gmail.com> (Christian Biesinger's message of "Thu, 17 Jun 2021 16:10:01 -0500")
>> + /* Ada type names are encoded, but it is better for users to see the
>> + decoded form. */
>> + if (ADA_TYPE_P (type))
>> + {
>> + std::string name = ada_decode (type->name (), false);
Christian> Would type->demangled_name() do the right thing? (And should this
Christian> respect the demangle option, maybe by calling type->print_name()?)
I don't think there is a demangled_name method on type, only on symbol.
It may make sense to add one, though this is really only an issue for
Ada AFAIK.
Tom
next prev parent reply other threads:[~2021-06-18 15:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 19:12 [PATCH 0/2] Change Ada type names reported by Python Tom Tromey
2021-06-17 19:12 ` [PATCH 1/2] Add non-wrapping mode to ada_decode Tom Tromey
2021-06-17 19:12 ` [PATCH 2/2] Decode Ada types in Python layer Tom Tromey
2021-06-17 21:10 ` Christian Biesinger
2021-06-18 15:09 ` Tom Tromey [this message]
2021-06-18 16:25 ` Christian Biesinger
2021-06-22 16:56 ` Tom Tromey
2021-06-25 14:02 ` [PATCH 0/2] Change Ada type names reported by Python Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87im2bus46.fsf@tromey.com \
--to=tromey@adacore.com \
--cc=cbiesinger@google.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).