From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/testsuite: use the correct .debug_str section name for DW_FORM_strp
Date: Fri, 19 Mar 2021 12:00:38 -0600 [thread overview]
Message-ID: <87im5nvxa1.fsf@tromey.com> (raw)
In-Reply-To: <20210318000423.138492-1-andrew.burgess@embecosm.com> (Andrew Burgess's message of "Thu, 18 Mar 2021 00:04:23 +0000")
>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:
Andrew> When handling DWARF attributes of the form DW_FORM_strp the strings
Andrew> should be placed in the .debug_str section, not .debug_string as they
Andrew> currently are by the DWARF assembler (in lib/dwarf.exp).
Ouch.
Andrew> I've added a test. This is as much to test the DWARF generator as it
Andrew> is to test GDB as GCC makes frequent use of DW_FORM_strp so we can be
Andrew> pretty sure this part of GDB is already well tested.
Andrew> gdb/testsuite/ChangeLog:
Andrew> * gdb.dwarf2/dw2-using-debug-str.c: New file.
Andrew> * gdb.dwarf2/dw2-using-debug-str.exp: New file.
Andrew> * lib/dwarf.exp (Dwarf::DW_FORM_strp): Create .debug_str section,
Andrew> not .debug_string.
This looks good. Thank you.
Tom
prev parent reply other threads:[~2021-03-19 18:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 0:04 Andrew Burgess
2021-03-19 18:00 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87im5nvxa1.fsf@tromey.com \
--to=tom@tromey.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).