From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gateway24.websitewelcome.com (gateway24.websitewelcome.com [192.185.51.59]) by sourceware.org (Postfix) with ESMTPS id B60273851C2E for ; Fri, 19 Mar 2021 18:01:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org B60273851C2E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=tom@tromey.com Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 6A5383B0F6 for ; Fri, 19 Mar 2021 13:00:39 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id NJQNl36aUPkftNJQNlhlO9; Fri, 19 Mar 2021 13:00:39 -0500 X-Authority-Reason: nr=8 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=hoPVQimq4aGw7g3M9ty0YFKl3mtE2F2azYIkWIUzSDM=; b=E1dQb+FdNNoMKFJCtnkxJalsAk FmJOek9OB775hSuwGVB7gNrE+khvCdJeRXXJ/T0x9AEXGXGcpyur8IXVOiKoV+REffiy2T1khhpHT QhF/trVHocww8WrbS9HDUIGzb; Received: from 71-211-137-228.hlrn.qwest.net ([71.211.137.228]:50288 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1lNJQM-000KEQ-Rk; Fri, 19 Mar 2021 12:00:38 -0600 From: Tom Tromey To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/testsuite: use the correct .debug_str section name for DW_FORM_strp References: <20210318000423.138492-1-andrew.burgess@embecosm.com> X-Attribution: Tom Date: Fri, 19 Mar 2021 12:00:38 -0600 In-Reply-To: <20210318000423.138492-1-andrew.burgess@embecosm.com> (Andrew Burgess's message of "Thu, 18 Mar 2021 00:04:23 +0000") Message-ID: <87im5nvxa1.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.137.228 X-Source-L: No X-Exim-ID: 1lNJQM-000KEQ-Rk X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-137-228.hlrn.qwest.net (murgatroyd) [71.211.137.228]:50288 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-Spam-Status: No, score=-3024.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, JMQ_SPF_NEUTRAL, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_NONE, SPF_HELO_PASS, SPF_NEUTRAL, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Mar 2021 18:01:39 -0000 >>>>> "Andrew" == Andrew Burgess writes: Andrew> When handling DWARF attributes of the form DW_FORM_strp the strings Andrew> should be placed in the .debug_str section, not .debug_string as they Andrew> currently are by the DWARF assembler (in lib/dwarf.exp). Ouch. Andrew> I've added a test. This is as much to test the DWARF generator as it Andrew> is to test GDB as GCC makes frequent use of DW_FORM_strp so we can be Andrew> pretty sure this part of GDB is already well tested. Andrew> gdb/testsuite/ChangeLog: Andrew> * gdb.dwarf2/dw2-using-debug-str.c: New file. Andrew> * gdb.dwarf2/dw2-using-debug-str.exp: New file. Andrew> * lib/dwarf.exp (Dwarf::DW_FORM_strp): Create .debug_str section, Andrew> not .debug_string. This looks good. Thank you. Tom