From: Tom Tromey <tom@tromey.com>
To: Shahab Vahedi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Shahab Vahedi <shahab.vahedi@gmail.com>,
Shahab Vahedi <shahab@synopsys.com>,
Tom Tromey <tom@tromey.com>,
Francois Bedard <fbedard@synopsys.com>
Subject: Re: [PATCH v2 1/2] arc: Take into account the REGNUM in supply/collect gdb hooks
Date: Thu, 10 Dec 2020 12:11:45 -0700 [thread overview]
Message-ID: <87im99mq6m.fsf@tromey.com> (raw)
In-Reply-To: <20201207163740.9128-2-shahab.vahedi@gmail.com> (Shahab Vahedi via Gdb-patches's message of "Mon, 7 Dec 2020 17:37:39 +0100")
>>>>> "Shahab" == Shahab Vahedi via Gdb-patches <gdb-patches@sourceware.org> writes:
Shahab> From: Shahab Vahedi <shahab@synopsys.com>
Shahab> All the arc_linux_supply_*() target operations and the
Shahab> arc_linux_collect_v2_regset() in arc-linux-tdep.c were
Shahab> supplying/collecting all the registers in regcache as if the
Shahab> REGNUM was set to -1.
Thanks for the patch.
Shahab> + /* regnum == -1 means writing all the registers. */
In the gdb style, "REGNUM" should be all-caps in that comment, as it
refers to the value of a variable.
This patch is ok with that nit fixed.
Tom
next prev parent reply other threads:[~2020-12-10 19:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 13:48 [PATCH 0/2] Add native GNU/Linux support for ARC in GDB Shahab Vahedi
2020-11-12 13:48 ` [PATCH 1/2] arc: Take into account the REGNUM in supply/collect gdb hooks Shahab Vahedi
2020-11-12 17:33 ` Tom Tromey
2020-11-12 17:36 ` Tom Tromey
2020-11-12 13:48 ` [PATCH 2/2] gdb: Add native support for ARC in GNU/Linux Shahab Vahedi
2020-11-12 18:03 ` Tom Tromey
2020-12-07 16:37 ` [PATCH v2 0/2] Add native GNU/Linux support for ARC in GDB Shahab Vahedi
2020-12-07 16:37 ` [PATCH v2 1/2] arc: Take into account the REGNUM in supply/collect gdb hooks Shahab Vahedi
2020-12-10 19:11 ` Tom Tromey [this message]
2020-12-07 16:37 ` [PATCH v2 2/2] gdb: Add native support for ARC in GNU/Linux Shahab Vahedi
2020-12-10 19:13 ` Tom Tromey
2020-12-10 19:33 ` Shahab Vahedi
2020-12-22 11:21 ` [PUSHED v2 1/2] arc: Take into account the REGNUM in supply/collect gdb hooks Shahab Vahedi
2020-12-22 11:21 ` [PUSHED v2 2/2] gdb: Add native support for ARC in GNU/Linux Shahab Vahedi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87im99mq6m.fsf@tromey.com \
--to=tom@tromey.com \
--cc=fbedard@synopsys.com \
--cc=gdb-patches@sourceware.org \
--cc=shahab.vahedi@gmail.com \
--cc=shahab@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).