From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from rock.gnat.com (rock.gnat.com [IPv6:2620:20:4000:0:a9e:1ff:fe9b:1d1]) by sourceware.org (Postfix) with ESMTP id 92E133857024 for ; Tue, 28 Jul 2020 19:31:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 92E133857024 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey@adacore.com Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 5ACFC116636; Tue, 28 Jul 2020 15:31:14 -0400 (EDT) X-Virus-Scanned: Debian amavisd-new at gnat.com Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id qQHjGw5vprSA; Tue, 28 Jul 2020 15:31:14 -0400 (EDT) Received: from murgatroyd (174-16-104-48.hlrn.qwest.net [174.16.104.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPSA id EF6E711662B; Tue, 28 Jul 2020 15:31:13 -0400 (EDT) From: Tom Tromey To: Pedro Alves via Gdb-patches Cc: Tom Tromey , Pedro Alves Subject: Re: [PATCH 2/3] Consistently use BFD's time References: <20200114210956.25115-1-tromey@adacore.com> <20200114210956.25115-3-tromey@adacore.com> <83wo9s4sac.fsf@gnu.org> <87k1044g1x.fsf@tromey.com> <83r1ucza8u.fsf@gnu.org> <87wo442wjq.fsf@tromey.com> <83o8pgz3lv.fsf@gnu.org> <83k104z2cb.fsf@gnu.org> <0b80b7da-d9f8-d517-920d-60572134096e@redhat.com> <87a70zvv6o.fsf@tromey.com> <87k102vm5y.fsf@tromey.com> <07179329-a5ac-6947-7303-c0d7b919aa39@redhat.com> X-Attribution: Tom Date: Tue, 28 Jul 2020 13:31:13 -0600 In-Reply-To: <07179329-a5ac-6947-7303-c0d7b919aa39@redhat.com> (Pedro Alves via Gdb-patches's message of "Sat, 20 Jun 2020 00:05:53 +0100") Message-ID: <87ime74eta.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-3.7 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, RCVD_IN_BARRACUDACENTRAL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jul 2020 19:31:15 -0000 >>>>> "Pedro" == Pedro Alves via Gdb-patches writes: Pedro> Can you clarify what do you see not work? I tried rebasing it Pedro> here, and it seems to work. It builds cleanly on GNU/Linux and Pedro> mingw32-w64 (both -m64 and -m32). I've pasted the resulting patch below. What if we apply this patch, but also apply a patch to our gnulib to avoid the timezone offsetting? We kept the code in gnulib/update-gnulib.sh to make this pretty easy to do, and we could try to work with upstream gnulib to make this feature optional (hopefully eliminating the need for our patch). This would avoid the mtime comparison problem. I don't know how to solve that another way, at least not without changing BFD to also use gnulib -- which seems to come with its own risks. Once we solve this somehow, I can rebase and update the original series here. This is one of the final blockers to the 10.1 branch, so it would be good to reach some kind of resolution soon. thanks, Tom