public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Daniel Xu <dxu@dxuuu.xyz>
Cc: gdb-patches@sourceware.org,  tom@tromey.com
Subject: Re: [PATCH] rust: Support raw identifiers
Date: Sat, 11 Jul 2020 16:05:42 -0600	[thread overview]
Message-ID: <87imetr9l5.fsf@tromey.com> (raw)
In-Reply-To: <20200704030430.822085-1-dxu@dxuuu.xyz> (Daniel Xu's message of "Fri, 3 Jul 2020 20:04:30 -0700")

>>>>> "Daniel" == Daniel Xu <dxu@dxuuu.xyz> writes:

Daniel> This patch adds rust raw identifier support. Raw identifiers are
Daniel> detailed here: https://doc.rust-lang.org/reference/identifiers.html .

Daniel>         PR 23427

This should be mentioned in both ChangeLog files, and should read
"PR rust/23427" -- the parser is a bit picky.

Daniel> @@ -1402,6 +1402,8 @@ rust_parser::lex_identifier (YYSTYPE *lvalp)
Daniel>    while ((pstate->lexptr[0] >= 'a' && pstate->lexptr[0] <= 'z')
Daniel>  	 || (pstate->lexptr[0] >= 'A' && pstate->lexptr[0] <= 'Z')
Daniel>  	 || pstate->lexptr[0] == '_'
Daniel> +	 || (pstate->lexptr[0] == '#' && pstate->lexptr - start == 1
Daniel> +             && *start == 'r')

This seems maybe a little roundabout, but OTOH the convenience variable
code isn't any better.

This patch is ok.  I think given the size we will need copyright
paperwork before we can check it in.  Do you have that?  If not, contact
me off-list and I will get you started.

thanks,
Tom

      reply	other threads:[~2020-07-11 22:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-04  3:04 Daniel Xu
2020-07-11 22:05 ` Tom Tromey [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87imetr9l5.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=dxu@dxuuu.xyz \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).