From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 4/5] gdb/python: New method to access list of register groups
Date: Thu, 18 Jun 2020 15:27:33 -0600 [thread overview]
Message-ID: <87imfoyshm.fsf@tromey.com> (raw)
In-Reply-To: <360af15dc7ea2e2e20f2b9ff6529467b7e0a0614.1592415322.git.andrew.burgess@embecosm.com> (Andrew Burgess's message of "Wed, 17 Jun 2020 18:38:08 +0100")
>>>>> "Andrew" == Andrew Burgess <andrew.burgess@embecosm.com> writes:
Andrew> Add a new method gdb.Architecture.register_groups which returns a new
Andrew> object of type gdb.RegisterGroupsIterator. This new iterator then
Andrew> returns objects of type gdb.RegisterGroup.
Andrew> Each gdb.RegisterGroup object just wraps a single reggroup pointer,
Andrew> and (currently) has just one read-only property 'name' that is a
Andrew> string, the name of the register group.
Andrew> As with the previous commit (adding gdb.RegisterDescriptor) I made
Andrew> gdb.RegisterGroup an object rather than just a string in case we want
Andrew> to add additional properties in the future.
FWIW this looks good to me.
thanks,
Tom
next prev parent reply other threads:[~2020-06-18 21:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 17:38 [PATCH 0/5] Python Unwinders and Inline Frames Andrew Burgess
2020-06-17 17:38 ` [PATCH 1/5] gdb: Remove deprecated_set_gdbarch_data Andrew Burgess
2020-06-18 21:11 ` Tom Tromey
2020-06-17 17:38 ` [PATCH 2/5] gdb/python: Add architecture method to gdb.PendingFrame Andrew Burgess
2020-06-17 18:20 ` Eli Zaretskii
2020-06-18 21:18 ` Tom Tromey
2020-06-17 17:38 ` [PATCH 3/5] gdb/python: Add gdb.Architecture.registers method Andrew Burgess
2020-06-17 18:25 ` Eli Zaretskii
2020-06-18 21:24 ` Tom Tromey
2020-06-17 17:38 ` [PATCH 4/5] gdb/python: New method to access list of register groups Andrew Burgess
2020-06-17 18:27 ` Eli Zaretskii
2020-06-17 18:40 ` Christian Biesinger
2020-06-18 8:44 ` Andrew Burgess
2020-06-18 21:27 ` Tom Tromey [this message]
2020-06-17 17:38 ` [PATCH 5/5] gdb: Fix Python unwinders and inline frames Andrew Burgess
2020-06-17 21:14 ` Luis Machado
2020-06-18 8:25 ` Andrew Burgess
2020-06-18 10:29 ` Luis Machado
2020-06-18 17:42 ` Andrew Burgess
2020-06-18 21:35 ` Tom Tromey
2020-06-22 15:47 ` Andrew Burgess
2020-06-23 14:16 ` Luis Machado
2020-07-02 21:07 ` Andrew Burgess
2020-07-06 17:43 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imfoyshm.fsf@tromey.com \
--to=tom@tromey.com \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).