From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51902 invoked by alias); 22 Feb 2020 00:40:13 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 51879 invoked by uid 89); 22 Feb 2020 00:40:12 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-7.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway30.websitewelcome.com Received: from gateway30.websitewelcome.com (HELO gateway30.websitewelcome.com) (50.116.127.1) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sat, 22 Feb 2020 00:40:11 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway30.websitewelcome.com (Postfix) with ESMTP id D1B99F26 for ; Fri, 21 Feb 2020 18:40:09 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 5Iq1jhKnGAGTX5Iq1jreEC; Fri, 21 Feb 2020 18:40:09 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=rbrLZYGmIqi1BpXPL89MuCtcDHwxYG2qzQttAS/x4Zc=; b=xp3RJZI/EURw29E1y30jYHwQkt 1NebAOJX7Q+SBQQr4/NzW7ubd9ra+Nn/XySBVUPDu+jWOmOVfemFSil/SEuuoZ8w8/zgz38s+fEXt sd1r242QPybUQm7pAGkBsDxIb; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:53928 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1j5Iq1-001tsr-Kt; Fri, 21 Feb 2020 17:40:09 -0700 From: Tom Tromey To: Luis Machado Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 11/14] Split type_unit_group References: <20200215165444.32653-1-tom@tromey.com> <20200215165444.32653-12-tom@tromey.com> <9bdecaec-1c1f-5633-f04d-f2189908f8ca@linaro.org> Date: Sat, 22 Feb 2020 00:40:00 -0000 In-Reply-To: <9bdecaec-1c1f-5633-f04d-f2189908f8ca@linaro.org> (Luis Machado's message of "Tue, 18 Feb 2020 09:08:12 -0300") Message-ID: <87imjz78uv.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-02/txt/msg00874.txt.bz2 >>>>> "Luis" == Luis Machado writes: >> + /* The symbol tables for this TU (obtained from the files listed in >> + DW_AT_stmt_list). >> + WARNING: The order of entries here must match the order of entries >> + in the line header. After the first TU using this type_unit_group, the >> + line header for the subsequent TUs is recreated from this. This is done >> + because we need to use the same symtabs for each TU using the same >> + DW_AT_stmt_list value. Also note that symtabs may be repeated here, >> + there's no guarantee the line header doesn't have duplicate entries. */ Luis> Does something need to be adjusted in the comments for "struct Luis> type_unit_unshareable" now that we've split these fields from the Luis> bigger type_unit_group struct? I think this all remained the same. Tom