From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/testsuite] Ignore pass/fail/unsupported in gdb-caching-proc.exp
Date: Thu, 13 Feb 2020 14:32:00 -0000 [thread overview]
Message-ID: <87imkapngd.fsf@tromey.com> (raw)
In-Reply-To: <20200213105754.GA22520@delia> (Tom de Vries's message of "Thu, 13 Feb 2020 11:57:56 +0100")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> 2020-02-13 Tom de Vries <tdevries@suse.de>
Tom> * gdb.base/gdb-caching-proc.exp (ignore_pass, ignore_fail)
Tom> (ignore_unsupported): New proc.
Tom> (test_proc): Temporarily rename pass/fail/ignore to
Tom> ignore_{pass,fail,ignore} in order to ignore PASS/FAIL/IGNORE messages
Tom> from the tested procs.
Can we just require that caching proc bodies not invoke tests?
Tom> + rename pass save_pass
Tom> + rename fail save_fail
Tom> + rename unsupported save_unsupported
Tom> + rename ignore_pass pass
Tom> + rename ignore_fail fail
Tom> + rename ignore_unsupported unsupported
In this situation perhaps it's best to catch any errors in the body, so
that the code to rename things back will always be run.
Then it could re-throw the error if needed at the end.
Tom
next prev parent reply other threads:[~2020-02-13 14:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-13 10:58 Tom de Vries
2020-02-13 14:32 ` Tom Tromey [this message]
2020-02-13 15:02 ` Tom de Vries
2020-02-17 20:52 ` Simon Marchi
2020-02-17 23:23 ` Tom de Vries
2020-02-17 23:58 ` Simon Marchi
2020-02-18 9:39 ` [committed][gdb/testsuite] Handle missing gnatmake in gnat_runtime_has_debug_info Tom de Vries
2020-02-18 10:59 ` [RFC][gdb/testsuite] Ignore pass in gdb_caching_proc Tom de Vries
2020-02-18 15:29 ` Tom Tromey
2020-02-19 6:07 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imkapngd.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).