From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36195 invoked by alias); 13 Feb 2020 14:32:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 36187 invoked by uid 89); 13 Feb 2020 14:32:38 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-8.1 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy= X-HELO: gateway33.websitewelcome.com Received: from gateway33.websitewelcome.com (HELO gateway33.websitewelcome.com) (192.185.145.4) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 13 Feb 2020 14:32:36 +0000 Received: from cm16.websitewelcome.com (cm16.websitewelcome.com [100.42.49.19]) by gateway33.websitewelcome.com (Postfix) with ESMTP id 74D396B3A01 for ; Thu, 13 Feb 2020 08:32:35 -0600 (CST) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 2FXfjDoh98vkB2FXfjBdDA; Thu, 13 Feb 2020 08:32:35 -0600 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=AUiXRDJ073AC4id1GKLLMz80Sn7q00y6hNnUL3rHNMs=; b=Zs3sGdZ7rtCC9QrHynOsIU8q6Z FB66Bwb6gRUtQA82tOhxD4ZWty0bsSPMCoqyYOWXau+qsPpOINtvPl9nVuE5XkHOIeYziGzqhFba5 qF7ys/rf4myQs/TY2hi0XOFZ1; Received: from 75-166-123-50.hlrn.qwest.net ([75.166.123.50]:56804 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92) (envelope-from ) id 1j2FXf-004MAu-5p; Thu, 13 Feb 2020 07:32:35 -0700 From: Tom Tromey To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH][gdb/testsuite] Ignore pass/fail/unsupported in gdb-caching-proc.exp References: <20200213105754.GA22520@delia> Date: Thu, 13 Feb 2020 14:32:00 -0000 In-Reply-To: <20200213105754.GA22520@delia> (Tom de Vries's message of "Thu, 13 Feb 2020 11:57:56 +0100") Message-ID: <87imkapngd.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2020-02/txt/msg00509.txt.bz2 >>>>> "Tom" == Tom de Vries writes: Tom> 2020-02-13 Tom de Vries Tom> * gdb.base/gdb-caching-proc.exp (ignore_pass, ignore_fail) Tom> (ignore_unsupported): New proc. Tom> (test_proc): Temporarily rename pass/fail/ignore to Tom> ignore_{pass,fail,ignore} in order to ignore PASS/FAIL/IGNORE messages Tom> from the tested procs. Can we just require that caching proc bodies not invoke tests? Tom> + rename pass save_pass Tom> + rename fail save_fail Tom> + rename unsupported save_unsupported Tom> + rename ignore_pass pass Tom> + rename ignore_fail fail Tom> + rename ignore_unsupported unsupported In this situation perhaps it's best to catch any errors in the body, so that the code to rename things back will always be run. Then it could re-throw the error if needed at the end. Tom