From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94551 invoked by alias); 16 Sep 2018 12:59:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 93964 invoked by uid 89); 16 Sep 2018 12:59:39 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway24.websitewelcome.com Received: from gateway24.websitewelcome.com (HELO gateway24.websitewelcome.com) (192.185.51.61) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 16 Sep 2018 12:59:38 +0000 Received: from cm15.websitewelcome.com (cm15.websitewelcome.com [100.42.49.9]) by gateway24.websitewelcome.com (Postfix) with ESMTP id 16B9040244 for ; Sun, 16 Sep 2018 07:59:37 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id 1We2gNDTdbXuJ1WeBgfV5v; Sun, 16 Sep 2018 07:59:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=tehJuCgEYbeDzNkVPb8HldylU7EHUYtOlae1d3jI2ek=; b=BEffzsEFTZWePZ6dVGwEcfvCDS vzeL9fxwSMDHz+4BHadqH2Y4qHfirzfuUwMV0Sz36UNMytA2XV5Y4TVrHHZsl3VfJBqC8XuCGniAH NXMSufQTzAOImDB/fY2Gqnc4F; Received: from 97-122-190-66.hlrn.qwest.net ([97.122.190.66]:46212 helo=bapiya) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1g1We2-0044ud-Jb; Sun, 16 Sep 2018 07:59:22 -0500 From: Tom Tromey To: Simon Marchi Cc: Tom Tromey , gdb-patches@sourceware.org Subject: Re: [PATCH 1/4] Change pspace_to_pspace_object to return a new reference References: <20180913053007.11780-1-tom@tromey.com> <20180913053007.11780-2-tom@tromey.com> <435d6db2-bbe9-7f79-3e3d-55ca8f2da0bc@simark.ca> Date: Sun, 16 Sep 2018 12:59:00 -0000 In-Reply-To: <435d6db2-bbe9-7f79-3e3d-55ca8f2da0bc@simark.ca> (Simon Marchi's message of "Sat, 15 Sep 2018 20:57:54 -0400") Message-ID: <87in35pphy.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2018-09/txt/msg00538.txt.bz2 >>>>> "Simon" == Simon Marchi writes: >> + gdbpy_ref<> pspace = pspace_to_pspace_object (obj->objfile->pspace); >> + return pspace.get (); >> } Simon> Can you double check this, shouldn't it be .release()? Otherwise, LGTM. Yes it should. Whoops :( I made this change. Tom