From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43756 invoked by alias); 24 Apr 2018 15:24:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 43695 invoked by uid 89); 24 Apr 2018 15:24:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: gateway24.websitewelcome.com Received: from gateway24.websitewelcome.com (HELO gateway24.websitewelcome.com) (192.185.50.71) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 24 Apr 2018 15:24:34 +0000 Received: from cm17.websitewelcome.com (cm17.websitewelcome.com [100.42.49.20]) by gateway24.websitewelcome.com (Postfix) with ESMTP id CA823B068D3 for ; Tue, 24 Apr 2018 10:24:32 -0500 (CDT) Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with SMTP id Azo0fzyTdy2aLAzo0fLwuH; Tue, 24 Apr 2018 10:24:32 -0500 X-Authority-Reason: nr=8 Received: from 97-122-176-117.hlrn.qwest.net ([97.122.176.117]:50886 helo=pokyo) by box5379.bluehost.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89_1) (envelope-from ) id 1fAzo0-002D0O-FK; Tue, 24 Apr 2018 10:24:32 -0500 From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org, Anton Kolesov Subject: Re: [RFA 6/6] Remove long_long_align_bit gdbarch attribute References: <20180424152222.8053-1-tom@tromey.com> <20180424152222.8053-7-tom@tromey.com> Date: Tue, 24 Apr 2018 15:24:00 -0000 In-Reply-To: <20180424152222.8053-7-tom@tromey.com> (Tom Tromey's message of "Tue, 24 Apr 2018 09:22:22 -0600") Message-ID: <87in8g8w5s.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-BWhitelist: no X-Source-L: No X-Exim-ID: 1fAzo0-002D0O-FK X-Source-Sender: 97-122-176-117.hlrn.qwest.net (pokyo) [97.122.176.117]:50886 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-SW-Source: 2018-04/txt/msg00473.txt.bz2 >>>>> "Tom" == Tom Tromey writes: Tom> This removes the long_long_align_bit gdbarch attribute in favor of Tom> type_align. This uncovered two possible issues. Tom> First, arc-tdep.c claimed that long long alignment was 32 bits, but Tom> gcc's arc.h says: Tom> #define ADJUST_FIELD_ALIGN(FIELD, TYPE, COMPUTED) \ Tom> (TYPE_MODE (strip_array_types (TYPE)) == DFmode \ Tom> ? MIN ((COMPUTED), 32) : (COMPUTED)) Tom> Here, DFmode means "double". So, I've implemented arc_type_align Tom> according to this. I do not have a good way to test this. Anton, could you take a look at this part of the patch? Tom