From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29637 invoked by alias); 23 Nov 2017 19:36:17 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29623 invoked by uid 89); 23 Nov 2017 19:36:16 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.7 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KB_WAM_FROM_NAME_SINGLEWORD,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=zaretskii, Eli, Zaretskii X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Nov 2017 19:36:15 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DF207267C4; Thu, 23 Nov 2017 19:36:13 +0000 (UTC) Received: from localhost (unused-10-15-17-193.yyz.redhat.com [10.15.17.193]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8A2045D6A5; Thu, 23 Nov 2017 19:36:11 +0000 (UTC) From: Sergio Durigan Junior To: Eli Zaretskii Cc: palves@redhat.com, qiyaoltc@gmail.com, brobecker@adacore.com, gdb-patches@sourceware.org Subject: Re: [PATCH v2] Add support for the --readnever command-line option (DWARF only) References: <1467838463-15786-1-git-send-email-brobecker@adacore.com> <87o9ntddb6.fsf_-_@redhat.com> <83bmjtasuy.fsf@gnu.org> Date: Thu, 23 Nov 2017 19:36:00 -0000 In-Reply-To: <83bmjtasuy.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 23 Nov 2017 17:59:33 +0200") Message-ID: <87ine0bxed.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00575.txt.bz2 On Thursday, November 23 2017, Eli Zaretskii wrote: >> From: Sergio Durigan Junior >> Cc: Yao Qi , Joel Brobecker , "gdb-patches\@sourceware.org" >> Date: Wed, 22 Nov 2017 19:54:53 -0500 >> >> - The patch appears to have been introduced as a workaround, at >> least initially; >> - The patch is far from perfect, as it simply shunts the load of >> DWARF debugging information, without really worrying about the >> other debug format. >> - Who really does non-symbolic debugging anyways? >> >> One use of this is when a user simply wants to do the following >> sequence: attach, dump core, detach. Loading the debugging information >> in this case is an unnecessary cause of delay. > > This use case should be mentioned in the manual. And I think if we > want to accept a patch that is DWARF specific, the name of the option > should reflect that; --readnever sounds misleading to me. > > (Another possibility would be to have a "maint dwarf" command to do > the same; maybe it's better.) Thanks for the review, Eli. According to Pedro's comments, I am working on the patch to make the feature available to other backends as well, so parts of the text will be changed. As for the use case, I've included it in the manual, as per Pedro's suggestion. >> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo >> index ab05a3718d..7d3d651185 100644 >> --- a/gdb/doc/gdb.texinfo >> +++ b/gdb/doc/gdb.texinfo >> @@ -1037,6 +1037,14 @@ Read each symbol file's entire symbol table immediately, rather than >> the default, which is to read it incrementally as it is needed. >> This makes startup slower, but makes future operations faster. >> >> +@item --readnever >> +@cindex @code{--readnever} >> +Do not read each symbol file's symbolic debug information. This makes >> +startup faster but at the expense of not being able to perform >> +symbolic debugging. >> + >> +This option is currently limited to debug information in DWARF format. >> +For all other format, this option has no effect. > ^^^^^^^^^^^^^^^^^^^^ > "For the others formats" Thanks; this part will most likely change due to the extension of the feature to the other backends. > And I think we need a NEWS entry for this new feature. Already added it. Thanks, -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/