From: Sergio Durigan Junior <sergiodj@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: GDB Patches <gdb-patches@sourceware.org>
Subject: Re: [PATCH 1/2] Use target_continue{,_no_signal} instead of target_resume
Date: Thu, 01 Sep 2016 18:57:00 -0000 [thread overview]
Message-ID: <87inuf30td.fsf@redhat.com> (raw)
In-Reply-To: <88f0aa5b-35de-4382-0a34-2c0df2ca1546@redhat.com> (Pedro Alves's message of "Wed, 31 Aug 2016 11:25:53 +0100")
On Wednesday, August 31 2016, Pedro Alves wrote:
> On 08/29/2016 05:11 AM, Sergio Durigan Junior wrote:
>
>> diff --git a/gdb/target/target.h b/gdb/target/target.h
>> index 76af732..1bfa1b0 100644
>> --- a/gdb/target/target.h
>> +++ b/gdb/target/target.h
>> @@ -70,4 +70,10 @@ extern void target_stop_and_wait (ptid_t ptid);
>>
>> extern void target_continue_no_signal (ptid_t ptid);
>>
>> +/* Restart a target previously stopped by target_stop_and_wait.
>
> Given you're using this function in other contexts, this sentence
> doesn't sound right. Likewise, the existing comment on top of
> target_continue_no_signal is no longer accurate.
Thanks, fixed and pushed.
049a857091cff98371b5688140832a3cf767153c
--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
prev parent reply other threads:[~2016-09-01 18:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-29 4:12 [PATCH 0/2] Consolidate target_{wait,resume} calls between GDB and gdbserver Sergio Durigan Junior
2016-08-29 4:12 ` [PATCH 2/2] Share target_wait prototype " Sergio Durigan Junior
2016-08-31 10:29 ` Pedro Alves
2016-08-31 10:30 ` Pedro Alves
2016-09-01 18:58 ` Sergio Durigan Junior
2016-08-29 4:12 ` [PATCH 1/2] Use target_continue{,_no_signal} instead of target_resume Sergio Durigan Junior
2016-08-31 10:25 ` Pedro Alves
2016-09-01 18:57 ` Sergio Durigan Junior [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87inuf30td.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).