From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 73815 invoked by alias); 1 Sep 2016 18:57:46 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 73806 invoked by uid 89); 1 Sep 2016 18:57:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=accurate X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 01 Sep 2016 18:57:36 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 024CB81243 for ; Thu, 1 Sep 2016 18:57:35 +0000 (UTC) Received: from localhost (unused-10-15-17-51.yyz.redhat.com [10.15.17.51]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u81IvYAo030490 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 1 Sep 2016 14:57:34 -0400 From: Sergio Durigan Junior To: Pedro Alves Cc: GDB Patches Subject: Re: [PATCH 1/2] Use target_continue{,_no_signal} instead of target_resume References: <1472443911-29056-1-git-send-email-sergiodj@redhat.com> <1472443911-29056-2-git-send-email-sergiodj@redhat.com> <88f0aa5b-35de-4382-0a34-2c0df2ca1546@redhat.com> X-URL: http://blog.sergiodj.net Date: Thu, 01 Sep 2016 18:57:00 -0000 In-Reply-To: <88f0aa5b-35de-4382-0a34-2c0df2ca1546@redhat.com> (Pedro Alves's message of "Wed, 31 Aug 2016 11:25:53 +0100") Message-ID: <87inuf30td.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2016-09/txt/msg00026.txt.bz2 On Wednesday, August 31 2016, Pedro Alves wrote: > On 08/29/2016 05:11 AM, Sergio Durigan Junior wrote: > >> diff --git a/gdb/target/target.h b/gdb/target/target.h >> index 76af732..1bfa1b0 100644 >> --- a/gdb/target/target.h >> +++ b/gdb/target/target.h >> @@ -70,4 +70,10 @@ extern void target_stop_and_wait (ptid_t ptid); >> >> extern void target_continue_no_signal (ptid_t ptid); >> >> +/* Restart a target previously stopped by target_stop_and_wait. > > Given you're using this function in other contexts, this sentence > doesn't sound right. Likewise, the existing comment on top of > target_continue_no_signal is no longer accurate. Thanks, fixed and pushed. 049a857091cff98371b5688140832a3cf767153c -- Sergio GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36 Please send encrypted e-mail if possible http://sergiodj.net/