From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16275 invoked by alias); 6 Jan 2015 03:09:00 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16251 invoked by uid 89); 6 Jan 2015 03:08:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 06 Jan 2015 03:08:53 +0000 Received: from svr-orw-fem-04.mgc.mentorg.com ([147.34.97.41]) by relay1.mentorg.com with esmtp id 1Y8KVl-0003AG-L4 from Yao_Qi@mentor.com ; Mon, 05 Jan 2015 19:08:49 -0800 Received: from GreenOnly (147.34.91.1) by svr-orw-fem-04.mgc.mentorg.com (147.34.97.41) with Microsoft SMTP Server id 14.3.224.2; Mon, 5 Jan 2015 19:08:48 -0800 From: Yao Qi To: "Steve Ellcey " CC: Subject: Re: [Patch] Fix build problem with system call in compile/compile.c References: Date: Tue, 06 Jan 2015 03:09:00 -0000 In-Reply-To: (Steve Ellcey's message of "Mon, 5 Jan 2015 16:44:21 -0800") Message-ID: <87iogkvc5a.fsf@codesourcery.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes X-SW-Source: 2015-01/txt/msg00064.txt.bz2 "Steve Ellcey " writes: Hi, Steve, Thanks for fixing this build failure... > /scratch/sellcey/repos/nightly_test/src/binutils-gdb/gdb/compile/compile.= c:175:10: error: ignoring return value of 'system', declared with attribute= warn_unused_result [-Werror=3Dunused-result] > cc1: all warnings being treated as errors > make[1]: *** [compile.o] Error 1 > make[1]: *** Waiting for unfinished jobs.... > make[1]: Leaving directory `/scratch/sellcey/repos/nightly_test/obj-mips-= img-linux-gnu/binutils-gdb/gdb' > make: *** [all-gdb] Error 2 > > I am not sure why other people aren't running into this but I would like = to > apply this patch to fix the build problem. Other people run into this too, Renlin Li opened PR 17718 for the build fai= lure, https://sourceware.org/bugzilla/show_bug.cgi?id=3D17718 and Chen Gang proposed a similar fix to the same problem https://sourceware.org/ml/gdb-patches/2015-01/msg00011.html This build failure wasn't fixed because people discuss that we can replace system ("rm -rf") with ftw/rmdir/unlink, https://sourceware.org/ml/gdb-patc= hes/2014-12/msg00501.html but the discussion looks stalled due to the holiday. It's unclear to me when the discussion can be closed and we have an acceptable fix. We should fix it by next week (7.9 branching). > > OK to checkin? I don't have an objection to this patch, but please wait for a while to see what do other people think of this patch. --=20 Yao (=E9=BD=90=E5=B0=A7)