From: Sergio Durigan Junior <sergiodj@redhat.com>
To: James Clarke <jrtc27@jrtc27.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][PR gdb/17046] Use standard setjmp.h on Darwin
Date: Mon, 15 Sep 2014 21:36:00 -0000 [thread overview]
Message-ID: <87iokova6d.fsf@redhat.com> (raw)
In-Reply-To: <1410816254-24831-1-git-send-email-jrtc27@jrtc27.com> (James Clarke's message of "Mon, 15 Sep 2014 22:24:14 +0100")
On Monday, September 15 2014, James Clarke wrote:
> The `machine/setjmp.h' header is no longer present on OS X 10.10, and is
> non-standard. Instead, `darwin-nat.c' should be using the standard
> `setjmp.h' header.
Thanks.
I am not a Mac user, and I know nothing about the details of the system,
but I did a little investigation and I think this is the right fix
indeed.
FWIW, I found
<https://lists.macosforge.org/pipermail/macports-tickets/2014-June/163911.html>
which is a related discussion.
This is not an approval, BTW.
> gdb/ChangeLog:
>
> 2014-09-15 James Clarke <jrtc27@jrtc27.com>
>
> PR gdb/17046
> * darwin-nat.c: Import standard setjmp.h rather than the non-standard
> machine/setjmp.h header that no longer exists as of OS X 10.10.
> ---
> gdb/darwin-nat.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gdb/darwin-nat.c b/gdb/darwin-nat.c
> index af4ec01..e550785 100644
> --- a/gdb/darwin-nat.c
> +++ b/gdb/darwin-nat.c
> @@ -42,7 +42,7 @@
>
> #include <sys/ptrace.h>
> #include <sys/signal.h>
> -#include <machine/setjmp.h>
> +#include <setjmp.h>
> #include <sys/types.h>
> #include <unistd.h>
> #include <signal.h>
> --
> 2.1.0
--
Sergio
GPG key ID: 0x65FC5E36
Please send encrypted e-mail if possible
http://sergiodj.net/
next prev parent reply other threads:[~2014-09-15 21:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 21:25 James Clarke
2014-09-15 21:36 ` Sergio Durigan Junior [this message]
2014-09-15 23:45 ` James Clarke
2014-09-16 8:41 ` Tristan Gingold
2015-01-06 22:42 ` Simon Marchi
2015-01-12 13:41 ` Simon Marchi
2015-01-12 17:21 ` Joel Brobecker
2015-01-12 17:49 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iokova6d.fsf@redhat.com \
--to=sergiodj@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=jrtc27@jrtc27.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).