From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3997 invoked by alias); 15 Sep 2014 21:36:01 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 3986 invoked by uid 89); 15 Sep 2014 21:36:00 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 15 Sep 2014 21:35:59 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8FLZtFg011363 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 15 Sep 2014 17:35:55 -0400 Received: from localhost (dhcp-10-15-16-169.yyz.redhat.com [10.15.16.169]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8FLZsdR025439 (version=TLSv1/SSLv3 cipher=AES128-GCM-SHA256 bits=128 verify=NO); Mon, 15 Sep 2014 17:35:54 -0400 From: Sergio Durigan Junior To: James Clarke Cc: gdb-patches@sourceware.org Subject: Re: [PATCH][PR gdb/17046] Use standard setjmp.h on Darwin References: <1410816254-24831-1-git-send-email-jrtc27@jrtc27.com> X-URL: http://www.redhat.com Date: Mon, 15 Sep 2014 21:36:00 -0000 In-Reply-To: <1410816254-24831-1-git-send-email-jrtc27@jrtc27.com> (James Clarke's message of "Mon, 15 Sep 2014 22:24:14 +0100") Message-ID: <87iokova6d.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00510.txt.bz2 On Monday, September 15 2014, James Clarke wrote: > The `machine/setjmp.h' header is no longer present on OS X 10.10, and is > non-standard. Instead, `darwin-nat.c' should be using the standard > `setjmp.h' header. Thanks. I am not a Mac user, and I know nothing about the details of the system, but I did a little investigation and I think this is the right fix indeed. FWIW, I found which is a related discussion. This is not an approval, BTW. > gdb/ChangeLog: > > 2014-09-15 James Clarke > > PR gdb/17046 > * darwin-nat.c: Import standard setjmp.h rather than the non-standard > machine/setjmp.h header that no longer exists as of OS X 10.10. > --- > gdb/darwin-nat.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/darwin-nat.c b/gdb/darwin-nat.c > index af4ec01..e550785 100644 > --- a/gdb/darwin-nat.c > +++ b/gdb/darwin-nat.c > @@ -42,7 +42,7 @@ > > #include > #include > -#include > +#include > #include > #include > #include > -- > 2.1.0 -- Sergio GPG key ID: 0x65FC5E36 Please send encrypted e-mail if possible http://sergiodj.net/