From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-106756-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 13872 invoked by alias); 28 Oct 2013 17:36:58 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 13857 invoked by uid 89); 28 Oct 2013 17:36:57 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 28 Oct 2013 17:36:57 +0000
Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9SHauxn024250	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)	for <gdb-patches@sourceware.org>; Mon, 28 Oct 2013 13:36:56 -0400
Received: from barimba (ovpn-113-94.phx2.redhat.com [10.3.113.94])	by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r9SHasqb025378	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO);	Mon, 28 Oct 2013 13:36:55 -0400
From: Tom Tromey <tromey@redhat.com>
To: Pedro Alves <palves@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH v4 1/9] fix latent bugs in ui-out.c
References: <1382464769-2465-1-git-send-email-tromey@redhat.com>	<1382464769-2465-2-git-send-email-tromey@redhat.com>	<526E80B1.6060202@redhat.com>
Date: Mon, 28 Oct 2013 17:36:00 -0000
In-Reply-To: <526E80B1.6060202@redhat.com> (Pedro Alves's message of "Mon, 28	Oct 2013 15:20:17 +0000")
Message-ID: <87iowhcn61.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-SW-Source: 2013-10/txt/msg00869.txt.bz2

>>>>> "Pedro" == Pedro Alves <palves@redhat.com> writes:

Pedro> On 10/22/2013 06:59 PM, Tom Tromey wrote:
>> The destructor code in ui-out.c has a latent bug, which is hidden by
>> the fact that nothing uses this right now.  This patch fixes the
>> problem.  The bug is that we don't always clear a pointer in the
>> ui-out object, leading to bad a free.

Pedro> "to a bad free"

Thanks, I've fixed this on my branch.

Tom