From: Tom Tromey <tromey@redhat.com>
To: Yao Qi <yao@codesourcery.com>
Cc: <gdb-patches@sourceware.org>
Subject: Re: [PATCH] Set entryval_error to NULL if entryval is set
Date: Thu, 08 Aug 2013 19:56:00 -0000 [thread overview]
Message-ID: <87iozg3qj6.fsf@fleche.redhat.com> (raw)
In-Reply-To: <52033F8A.4020809@codesourcery.com> (Yao Qi's message of "Thu, 8 Aug 2013 14:49:46 +0800")
>>>>> "Yao" == Yao Qi <yao@codesourcery.com> writes:
>> The bug fix part looks ok to me, but I think you need a special test
>> case in order to really test entry values. Or to put it another way,
>> what happens if this test is run with a compiler that doesn't emit entry
>> value information?
Yao> Patch in gdb.trace/collection.exp is to test arguments and/or entry
Yao> values are shown properly, without the internal error. Testing the
Yao> contents of entry values is not the point of this test and the patch.
I've re-read the patch and I think that I was misunderstanding what it
was doing. In particular I missed the "set print entry-values only" bit.
The patch is ok.
thanks,
Tom
next prev parent reply other threads:[~2013-08-08 19:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-05 8:17 Yao Qi
2013-08-05 8:26 ` Agovic, Sanimir
2013-08-05 14:06 ` Tom Tromey
2013-08-08 6:50 ` Yao Qi
2013-08-08 19:56 ` Tom Tromey [this message]
2013-08-09 0:36 ` Yao Qi
2013-08-05 14:17 ` Pedro Alves
2013-08-09 16:28 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87iozg3qj6.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=yao@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).