From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32454 invoked by alias); 8 Aug 2013 19:56:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 32442 invoked by uid 89); 8 Aug 2013 19:56:40 -0000 X-Spam-SWARE-Status: No, score=-5.2 required=5.0 tests=AWL,BAYES_00,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.1 Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 08 Aug 2013 19:56:40 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r78JuVUP006233 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 8 Aug 2013 15:56:32 -0400 Received: from barimba (ovpn-113-128.phx2.redhat.com [10.3.113.128]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r78JuTq5030170 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NO); Thu, 8 Aug 2013 15:56:31 -0400 From: Tom Tromey To: Yao Qi Cc: Subject: Re: [PATCH] Set entryval_error to NULL if entryval is set References: <1375690566-7417-1-git-send-email-yao@codesourcery.com> <874nb4b5b3.fsf@fleche.redhat.com> <52033F8A.4020809@codesourcery.com> Date: Thu, 08 Aug 2013 19:56:00 -0000 In-Reply-To: <52033F8A.4020809@codesourcery.com> (Yao Qi's message of "Thu, 8 Aug 2013 14:49:46 +0800") Message-ID: <87iozg3qj6.fsf@fleche.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SW-Source: 2013-08/txt/msg00254.txt.bz2 >>>>> "Yao" == Yao Qi writes: >> The bug fix part looks ok to me, but I think you need a special test >> case in order to really test entry values. Or to put it another way, >> what happens if this test is run with a compiler that doesn't emit entry >> value information? Yao> Patch in gdb.trace/collection.exp is to test arguments and/or entry Yao> values are shown properly, without the internal error. Testing the Yao> contents of entry values is not the point of this test and the patch. I've re-read the patch and I think that I was misunderstanding what it was doing. In particular I missed the "set print entry-values only" bit. The patch is ok. thanks, Tom