From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 772883839391 for ; Wed, 5 Jun 2024 09:20:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 772883839391 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 772883839391 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717579226; cv=none; b=g6z6yE4VpoNiqq3HCT93PKfvEsI+nWoWZwCzaDaU3NUnsV1EBLc6OR1OO1IW12uO8BAGvI26ghdQuYKf0aNOXlqoDlKB+z1hQI7zgTD8XOBxYmv2u5H3E7gwNnxY6kMSw02n0DadrE/mcT/sOGqoWy4UQUs/cq5tGihDvYExLpA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1717579226; c=relaxed/simple; bh=CzJYOwx1WoDU6w1y52u1WOTv0gPQviFVDfy82+hylFc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=djUqIKqD7kMnw+N4bwddpD3zaTXa+7+C/1Wl3XjlWHULeoRooiSCEUTYmfW6DlAwMw/T6STBtwyWzsVnfEwIOTpS0VEOor8OsDXKI9XZ4Wd9FZbqIv9GBLlnjgcOq27qZ5evB/QLpnI5G08S84XzWlZe/i4uWtDGceQHbPTrLDU= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1717579223; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=TWuiRgb6nIgvIhqxH+ov7m7zRL0KAi4biuQatUnBf40=; b=Zxyngr3IpW7kk+T8Go4bv4mcbEZ3TOBLkT6UjE66J8/uq7PbzVKKmviwHaiHPF6NbWHkZy GgDZZFRi+G80icsalRaaN+b0btztLbFliv7zxEfNdUF4uc33Bpf/evTgm0U+tTGLGSukoE zohs0pMPS4cNpiOoaZVduYiSD71qwlg= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-168-hNBd6UQCMfKXki52j9efhQ-1; Wed, 05 Jun 2024 05:20:21 -0400 X-MC-Unique: hNBd6UQCMfKXki52j9efhQ-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-42159936ec2so1016475e9.1 for ; Wed, 05 Jun 2024 02:20:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717579220; x=1718184020; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TWuiRgb6nIgvIhqxH+ov7m7zRL0KAi4biuQatUnBf40=; b=Si7ACvnFuiHO1aH37xrPHkPgS5A7319WHOd0L5swPZGETLFg1/d+oO5eydocafwSlA yEBEZqdo2gYiOuMn78wr7H788P8oen+N8Qc8VT+OZqMmvJhiCs+WJC0CxPdBGCrFcfho PcqHdke2XJqthPksimCETr6LjCexAiVKQElGRrkf/cvHCoaUWBQwVLA0nUO7yYCQoWxn YSltt4DM+jSYJHpI6as62N5My6RYyDQhBA7rS3Avye3se6I11oSHK3YA0YdlWJwYa+A/ g2zgM1mKvnKI3oZV4Q/3p7lwvs0ufh9tpSVJhG6cz9v26xd2gYtLj8T+bMvPP4hw5v/G RAcQ== X-Gm-Message-State: AOJu0YwZvyFdy5U7TwNxJVWHriiN5fZ3jtlUbpb6NjeCyQb/dS3bXeWr Zkg8MkAAUkJcMZ5rMZyenkqPDXBdlAXJsl95d8KDFgHb9d/ftADzr/rclHWM8v0AiJtjJvT1Prz TZGHBoIshLO0KW5UIXtoT/yETJUd5H2Qy59yUbELhDn2I9E1YoDeeAVWyQD56ExYgPCc= X-Received: by 2002:a05:600c:470f:b0:421:2990:7f8b with SMTP id 5b1f17b1804b1-421562c1da4mr14318555e9.3.1717579219781; Wed, 05 Jun 2024 02:20:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGPhu/Uoe8lSPTW+FnE0ElyRGb8Ywbd1u29HSC94+ly5kKfVIHXJPfeS9KQNrE2BTkFIrQkwg== X-Received: by 2002:a05:600c:470f:b0:421:2990:7f8b with SMTP id 5b1f17b1804b1-421562c1da4mr14318415e9.3.1717579219308; Wed, 05 Jun 2024 02:20:19 -0700 (PDT) Received: from localhost ([31.111.84.186]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-42158101722sm13914035e9.4.2024.06.05.02.20.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Jun 2024 02:20:19 -0700 (PDT) From: Andrew Burgess To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 1/4] gdb/testsuite: remove trailing \r from rust_llvm_version result In-Reply-To: <87h6e8q0hv.fsf@tromey.com> References: <87h6e8q0hv.fsf@tromey.com> Date: Wed, 05 Jun 2024 10:20:17 +0100 Message-ID: <87jzj3wxta.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom Tromey writes: >>>>>> "Andrew" == Andrew Burgess writes: > > I saw your note about ignoring this series but... > > Andrew> This commit makes two fixes: > > Andrew> 1. I use regsub to convert all '\r\n' sequences to '\n'; now when we > Andrew> split on '\n' the lines will not end in '\r'. > > Andrew> 2. Within the loop over lines block I now check the line contents > Andrew> rather than the unsplit full output; now we capture a value > Andrew> without a trailing '\r'. > > ... I think this is worthwhile on its own. > > Approved-By: Tom Tromey I've gone ahead and pushed just this patch. Thanks, Andrew