From: Tom Tromey <tom@tromey.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: gdb-patches@sourceware.org, Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH 1/3] gdb/tui: change some macros to functions
Date: Mon, 03 Jun 2024 08:55:25 -0600 [thread overview]
Message-ID: <87jzj6qdnm.fsf@tromey.com> (raw)
In-Reply-To: <20240531025414.4153372-1-simon.marchi@polymtl.ca> (Simon Marchi's message of "Thu, 30 May 2024 22:54:05 -0400")
>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
Simon> From: Simon Marchi <simon.marchi@efficios.com>
Simon> Change the `TUI_*` macros to access known windows to functions. Define
Simon> them in their respective files, because trying to define them in
Simon> tui-data.h would end up causing include cycles.
Simon> This makes static analysis (detection of unused include files in this
Simon> case) more accurate, and I think in general we should avoid hiding
Simon> code behind macros if not necessary.
Ok.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
prev parent reply other threads:[~2024-06-03 14:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 2:54 Simon Marchi
2024-05-31 2:54 ` [PATCH 2/3] gdb: add IWYU export pragams to gdb_curses.h Simon Marchi
2024-06-03 14:56 ` Tom Tromey
2024-06-08 3:07 ` Simon Marchi
2024-05-31 2:54 ` [PATCH 3/3] gdb/tui: cleanup includes Simon Marchi
2024-06-03 14:57 ` Tom Tromey
2024-06-08 10:14 ` Tom de Vries
2024-06-09 14:14 ` Simon Marchi
2024-06-10 8:44 ` Tom de Vries
2024-06-12 4:29 ` Aditya Kamath1
2024-06-09 5:51 ` Aditya Kamath1
2024-06-03 14:55 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzj6qdnm.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).