From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 4A7B83858D35 for ; Tue, 7 May 2024 15:28:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4A7B83858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4A7B83858D35 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715095687; cv=none; b=MwtKwlX2R1H/l9Fzi7HrYHretkGnuSX54gY7l5X8deucHkkcNeEm+GHERvH2dz7+7UAAr76uuc2Ik0fnyyJWYPvpBQQf7+beadUzydfIkL3BlxHNd91tmLntMyoFHVFGSiD+5j+B46qT5ErWTpI6BxbhotRBYxGdMrUBKxd0Tco= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715095687; c=relaxed/simple; bh=xU5RJEomeNOSZyOafhrF6PfpXUclTaXLcdaIHl9R2Ss=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=LebSaC+huKc0f2omWYeHtWZRBzKY3L4TNFpfvQA2KGb9NhQ2Kpj7CdI5lOQQKBxrXYC4HsmxJ7/Kb8XpPKznWfnawZ4nMkUgOjERejms9p0IPW4AtodO2axb/9ZKsJycxSI86PxqCQ9yfIfGkdGTQvdp6QfbG/hDDIMD66X8QJQ= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1715095685; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+zf3KcZwQJLJ2ihYyvx68znmx6yuul0wcg94+A8Xa/A=; b=WN/71n7SiDzpq8u6pS+jUm7GVFvkUr5sXfNEPn3zq4nugEXHQ8gd/A0qsTV3BxQ7HQYAl4 eaSrfrtG44O3YeniV6A4D6eGMlcOOs1Z/Zwr1DoOQwAj+6rS5YYDlu61z2l2g3tiv3Ta+B ANdomDknLP8mJaNEBcTrcjsgizvuRk8= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-624-YEZt3zyxPK-cO27fBaWjmQ-1; Tue, 07 May 2024 11:28:04 -0400 X-MC-Unique: YEZt3zyxPK-cO27fBaWjmQ-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-41dc9c831acso28105285e9.0 for ; Tue, 07 May 2024 08:28:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715095683; x=1715700483; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+zf3KcZwQJLJ2ihYyvx68znmx6yuul0wcg94+A8Xa/A=; b=Y6OxV1bJujkUnHT2uJ2UxmmIXzw5SieoSW3qVpnop7oAoaQmm5deTNAZdvYDBikAa6 kkidkD/+J2+t0xXWjST1CaAaNZ7fBzIfRk2TueD0CiKqumoErmGJAXKC9jbu8c9Jufhz EncG9s50806lcCoqw1Kg9i+FuFx7r0v1SvoOr9JpEI1mEZdKpX1ed8CA7gB9RsOOfAK4 wXHetosviEDvY1xxgy5PVZrYCaQkYIzMOklFgQRRZRxLF95NF+0bKngzOWGbH9bwwZmq uj7IHNfO6UWzOyP76i3O35ywMiCivJTZi061giiZtPwJFzB5Weune9XLtmkUawo5CsOT avVA== X-Forwarded-Encrypted: i=1; AJvYcCX25HI7GWtQXbGxqVnaqEOTdhqIuiRJ16A0FIJG7PLCIb3WXq6itinZPA4/2xBmvrBK8Ca6+0urhCRO2VOSg3/JroAecFDiWNMXyQ== X-Gm-Message-State: AOJu0Yx+L/5mmWI4iB+op4FCM9EWHhZ7jGNlZKNrRCA/Qswx0hcWthOM /+3FRkCOzELmygNIXaR06Tjbv5hy1O3Ky73VA56lyBN3eL32OKor8UAqjbOXsiDc68uKGtGclle d4gFCBUOuik1DKrBEvS8UikdN6IcbcDgJDlAmJX90RAvwfXcP7Twj0MEuLkY= X-Received: by 2002:a05:600c:154c:b0:41b:9427:562e with SMTP id 5b1f17b1804b1-41f71cc25c5mr1452135e9.12.1715095683205; Tue, 07 May 2024 08:28:03 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG8EHee2O4Vtg9iB3H0+q6lkctb8AApSrXd23qgnmgMDHMGb4YNnAQ28lw1vjM6yb4RkL8RKw== X-Received: by 2002:a05:600c:154c:b0:41b:9427:562e with SMTP id 5b1f17b1804b1-41f71cc25c5mr1451855e9.12.1715095682633; Tue, 07 May 2024 08:28:02 -0700 (PDT) Received: from localhost ([31.111.84.240]) by smtp.gmail.com with ESMTPSA id bi15-20020a05600c3d8f00b0041c24321934sm23775288wmb.41.2024.05.07.08.28.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 08:28:02 -0700 (PDT) From: Andrew Burgess To: "Willgerodt, Felix" , "gdb-patches@sourceware.org" Cc: John Baldwin Subject: RE: [PATCHv5 02/11] gdbserver: convert have_ptrace_getregset to a tribool In-Reply-To: References: <461c1ea75f7149b8d4ef431085cb7dbc0f9bd6b2.1714143669.git.aburgess@redhat.com> Date: Tue, 07 May 2024 16:28:00 +0100 Message-ID: <87jzk5tzen.fsf@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: "Willgerodt, Felix" writes: >> -----Original Message----- >> From: Andrew Burgess >> Sent: Freitag, 26. April 2024 17:02 >> To: gdb-patches@sourceware.org >> Cc: Andrew Burgess ; Willgerodt, Felix >> ; John Baldwin >> Subject: [PATCHv5 02/11] gdbserver: convert have_ptrace_getregset to a tribool >> >> Convert the have_ptrace_getregset global within gdbserver to a >> tribool. This brings the flag into alignment with the corresponding >> flag in GDB. >> >> The gdbserver have_ptrace_getregset variable is already used as a >> tribool, it just doesn't have the tribool type. >> >> In a future commit I plan to share more code between GDB and >> gdbserver, and having this variable be the same type in both code >> bases will make the sharing much easier. >> >> There should be no user visible changes after this commit. >> >> Approved-By: John Baldwin >> --- >> gdbserver/linux-arm-low.cc | 6 +++--- >> gdbserver/linux-low.cc | 2 +- >> gdbserver/linux-low.h | 2 +- >> gdbserver/linux-x86-low.cc | 10 +++++----- >> 4 files changed, 10 insertions(+), 10 deletions(-) > > > Reviewed-By: Felix Willgerodt > > Looks fine to me, x86 parts are approved. I've also pushed this patch from this series as it's only loosely related to the rest of the series. Thanks, Andrew