From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb/testsuite] Fix gdb.threads/access-mem-running-thread-exit.exp with clang
Date: Wed, 10 Apr 2024 10:00:09 -0600 [thread overview]
Message-ID: <87jzl54392.fsf@tromey.com> (raw)
In-Reply-To: <20240410101943.2981-1-tdevries@suse.de> (Tom de Vries's message of "Wed, 10 Apr 2024 12:19:43 +0200")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
Tom> When running test-case gdb.threads/access-mem-running-thread-exit.exp with
Tom> clang, we run into:
Tom> ...
Tom> (gdb) print global_var = 555^M
Tom> No symbol "global_var" in current context.^M
Tom> (gdb) FAIL: gdb.threads/access-mem-running-thread-exit.exp: all-stop: \
Tom> access mem (write to global_var, inf=2, iter=1)
Tom> ...
Tom> The problem is that clang removes the unused variable.
Tom> Fix this in the same way as done in commit b4f767131f7
Tom> ("Fix gdb.base/align-*.exp and Clang + LTO and AIX GCC"), by incrementing the
Tom> variable.
Tom> Tested on x86_64-linux with gcc and clang.
Seems fine to me.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
prev parent reply other threads:[~2024-04-10 16:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-10 10:19 Tom de Vries
2024-04-10 16:00 ` Tom Tromey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzl54392.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).