From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x34.google.com (mail-oa1-x34.google.com [IPv6:2001:4860:4864:20::34]) by sourceware.org (Postfix) with ESMTPS id 07A893858D1E for ; Sat, 6 Apr 2024 04:13:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 07A893858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 07A893858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:4860:4864:20::34 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712376804; cv=none; b=v43M6UQucT/ZLoCM7W3JtlODnobGRKyx4z8KYiNDoUwGTWiQP5Hf3p5kuLdxlVsdgiLVqJdUYhLX+fMwGFw+h5/Eu9Szf57gRJDUIBvMyjDwjnC4k/1BkXZPCJFaC8r4msXMXLCq9YyDhnu94se/hrKeDtxoxbjLNRKtu/KkN+c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712376804; c=relaxed/simple; bh=zTYr04drwQUdxXx1Gl/ja4ZRGRDt2sANe67I/kHLAjo=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Ij8NUEoole6GcYdtkmEGZR4mYefsTVQRcAcxgpWAY6NlppSoG95uU9HZa/WrUSRjsYEMfTSskMwprX+0U1O13cw3FxmjjPKRGkxfVwQ7AnXFd4XOg8/xU+z1Sft5KTL0GcozblzPI9xlZR3IseG+qoU7HaVGPYJETQmGdy0qXbw= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-oa1-x34.google.com with SMTP id 586e51a60fabf-229d01e81f1so1564382fac.2 for ; Fri, 05 Apr 2024 21:13:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1712376801; x=1712981601; darn=sourceware.org; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=i7Fd+L+aQvowkJNMvYtG7FpMwTK0QPFH6HL2/3gAWQA=; b=AnRu7Gne3abZA+rPsJEuvtruvvdANnjO6Ua+h1pGZ7bkXSB9wcLnhI6EQgs99yCW0G 19D65u1YqV6COlwQ1PbfqkUrDptJdIvmOXlVNrHkkojYrWt2k+leUidbqR+YxF3G2I2d 1FI+O1SyCdJKo7k+79EWOeAq8pLeKnaVDl5kxq96ulyN2q3ail+KRLhYlX7BsfFwUr2R Bt1wYkWyiJR5VPiI+8qK54b/yVE+DXjje+RfQfDN7WE0Z9WzVk1M4g+g2JC1vOJD/fkm YREqDQ3Gaey6rbez8WnhIytr9ruRGFK764YSs6DabBltsOxblqo51CLd2HSAbOGr2gl/ FG7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712376801; x=1712981601; h=mime-version:message-id:date:user-agent:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=i7Fd+L+aQvowkJNMvYtG7FpMwTK0QPFH6HL2/3gAWQA=; b=ewh93yhqzfy2LPkIVVCtfk0JK3wwDWRGGBEiW+/pNUFxNkv6029KRUjBbKFlsUXsml 70Qz4rJczysvGTwHMecZZWpkBN27FctjVAwF7W1puY2tX7FzyUM7mLmmS06TvsD8WBxz nVQgFQlt6bZ2ivUpJr66PBvkvQrrcTGn2e+Okfe8sOKT+O1tW55pm5JPrZQFEFolWfJW BYnEnSbCR8pgReJXwN0x9kQAAWqJgV3yWkoogv4WD+GaSvXtFyDPWRSlrwL21QAF7gUn kuM6Muo3F7t9cpus9O6wm7cLjiQaUVQ6EfLXaHlb9o3sZlCYjio84M4mvRQ427g9kH0P F+Yw== X-Gm-Message-State: AOJu0Yx7pwuWOllDRzyIYYW3YeDv+U0Uy+COC1dN0F7LWr3N+SU/VoU6 VZudofCp+ZQp/mPPz1rY97q8aG6b8vNE/m8/khU75+f6h7n/0PNhloKMW12Af5k89Pefg2LJ1WO d X-Google-Smtp-Source: AGHT+IE3tNXCYPtgmEzyzULV04HQtUfoVRrkNrehDjXXXWWt7jmN66WkIfBghYhvdp8831E3Q4RSJA== X-Received: by 2002:a05:6870:418d:b0:22e:ab27:308d with SMTP id y13-20020a056870418d00b0022eab27308dmr3998921oac.46.1712376801206; Fri, 05 Apr 2024 21:13:21 -0700 (PDT) Received: from localhost ([2804:14d:7e39:8470:8e61:5c78:78b:6f3e]) by smtp.gmail.com with ESMTPSA id f34-20020a056a000b2200b006ea918dab9csm2335648pfu.157.2024.04.05.21.13.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 05 Apr 2024 21:13:20 -0700 (PDT) From: Thiago Jung Bauermann To: Christophe Lyon Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: Add missing install-dvi Makefile target In-Reply-To: <20240404215910.57477-1-christophe.lyon@linaro.org> (Christophe Lyon's message of "Thu, 4 Apr 2024 21:59:10 +0000") References: <20240404215910.57477-1-christophe.lyon@linaro.org> User-Agent: mu4e 1.12.2; emacs 29.3 Date: Sat, 06 Apr 2024 01:13:18 -0300 Message-ID: <87jzlb9li9.fsf@linaro.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello Christophe, Thank you for the patch! Just a couple of minor comments: Christophe Lyon writes: > For some reason install-dvi is missing although other targets of the > same family are present. This looks like an oversight. > > This enables calling 'make install-dvi' from the top-level build > directory. I can confirm that 'make install-dvi' works from inside $BUILD/gdb, but from $BUILD I get this error: Doing install-dvi in libdecnumber make[2]: Entering directory '/home/thiago.bauermann/.cache/builds/gdb-native/libdecnumber' make[2]: *** No rule to make target 'install-dvi'. Stop. make[2]: Leaving directory '/home/thiago.bauermann/.cache/builds/gdb-native/libdecnumber' make[1]: *** [Makefile:7855: install-dvi-libdecnumber] Error 1 make[1]: Leaving directory '/home/thiago.bauermann/.cache/builds/gdb-native' make: *** [Makefile:1669: do-install-dvi] Error 2 With 'make -k' I see that gdbserver also lacks an install-dvi target. > @@ -233,7 +236,7 @@ Doxyfile-gdb-xref: $(srcdir)/Doxyfile-gdb-xref.in > Doxyfile-gdbserver: $(srcdir)/Doxyfile-gdbserver.in > $(doxyedit) $(srcdir)/Doxyfile-gdbserver.in >Doxyfile-gdbserver > > -all-doc: info dvi ps # pdf > +all-doc: info dvi ps pdf > diststuff: info man > rm -f gdb-cfg.texi > This seems unrelated. -- Thiago