From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-xd2b.google.com (mail-io1-xd2b.google.com [IPv6:2607:f8b0:4864:20::d2b]) by sourceware.org (Postfix) with ESMTPS id 6D5953858CD1 for ; Tue, 19 Mar 2024 16:06:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6D5953858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6D5953858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::d2b ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710864420; cv=none; b=xjDtPAl6i5wogphRUVskwPUw9weREsj2YwuhuXi36JHAXUT1Q4s5TtsRzVEwGNuzwD37JZiHuvdn/BL+um6OaVK6ezaJgi3XLx/adYrn9QkSXYXsBWbhvaTmTxqP2RrDa0zXd0+vQZE43uq1MVH2C3Jr+SsoI0XLex2Y9Cga7Bk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1710864420; c=relaxed/simple; bh=GSiiQmFFU5l8+A/CdHaj8/ghAT10SYEaaZi4IIyqC/A=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=X7tEHzANbdsrZsfOOmofYmaOrggSVzQdQ2iPdppnysJQdUbAr7nG6WBopMxCsarpOctAPn+OJexHJaoUB9AzCN2e1UZDxowFhrPPGxei0ejtiUC12dfTPhryUPbbYJlAZd+6M1Qffw+o/fhLeptgeFuhBw3xFIjgJaPzCxqPbb8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-io1-xd2b.google.com with SMTP id ca18e2360f4ac-7cc864215caso58295639f.3 for ; Tue, 19 Mar 2024 09:06:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1710864409; x=1711469209; darn=sourceware.org; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=GSiiQmFFU5l8+A/CdHaj8/ghAT10SYEaaZi4IIyqC/A=; b=WwoIiYBmfa/XM22eOOaJDR2IKrWEKHkRpWv2PBHPJwkoKrpSAufPY2SVvMxcPfTKh5 mNWVd54+xbVSC+OihSy8zCgAi5zibb+qEqrpMAXIez0keWj+F4seRud8U9p89J657+Y0 RCXJ1UJALsmAXyIKgJH/U6pVoTNxceuDzO2O9gd+iO1PPQkQuo+iFyV5iPFZ4y498r0L cfym73QoyJ727ObDEvO25KKNjhRAxs6NsM+7yN6nuBQW4DG3w9J0bisyDb4jJx//dtDa RzHzix8N3jA2tRSSct0ARenGCYYguWz0G3Y1IYn07JrAitToDm81RMT9Tiw2DZqp9QTx ijAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710864409; x=1711469209; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GSiiQmFFU5l8+A/CdHaj8/ghAT10SYEaaZi4IIyqC/A=; b=cI0H5imrjmBdCSKJYvaP3Z/jYoLfiOKUUZh2/kcCdPNz5ni9rvcRPLs4TkoJBZT6ps q/ZvhduUEcMorwte0sUXp3adVIuDYKkKum9rkCF915jArkv96nleUZ2tC2OXYUiwx8Rw cppJIy78bY1muKsIQa0BORRFlBNYb4oPZxO40HVzM8OPy9V4qBWZBt+sDBC6anNNz48T A1TK/FLHdZBxBXTfS6siIIBSE1qGfpQpxQd/be7l4cQckJRstqq+d7jCrIT8mpmBDNKF F1nPxYOg0v/gcwysg0uiRfHpijI5x6c1viQPnZyKyxbcl25kqy+HgviPbVdPQ+uuUaTW 9T1A== X-Gm-Message-State: AOJu0Yzo6iS2B5x50tNlZuSskWPuIqYSwHDHYpUngCaWS8HvoYxiGF5b Hcvhnw8BS7ZEfCLGpCnHHp6VMILHuhT0CQT0T34qCEdYrfIRCCSFOdF6pX6rMcsw5kMg76uPgRw = X-Google-Smtp-Source: AGHT+IGH3ONUx5/yGtbPm6SlKkqnxRaucZMbwDYIiyVibXRoJJd/LoYNqLPBDIihQaBXEnbe/2t45Q== X-Received: by 2002:a6b:fe02:0:b0:7cc:392:7c9c with SMTP id x2-20020a6bfe02000000b007cc03927c9cmr11951320ioh.17.1710864409648; Tue, 19 Mar 2024 09:06:49 -0700 (PDT) Received: from murgatroyd (97-122-82-115.hlrn.qwest.net. [97.122.82.115]) by smtp.gmail.com with ESMTPSA id t130-20020a6bc388000000b007c9df5d8742sm3312483iof.44.2024.03.19.09.06.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Mar 2024 09:06:49 -0700 (PDT) From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] Fix two serious flake8 reports References: <20240223190641.3662803-1-tromey@adacore.com> X-Attribution: Tom Date: Tue, 19 Mar 2024 10:06:48 -0600 In-Reply-To: <20240223190641.3662803-1-tromey@adacore.com> (Tom Tromey's message of "Fri, 23 Feb 2024 12:06:41 -0700") Message-ID: <87jzlygq93.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey writes: Tom> flake8 points out that some code in frame_filters.py is referring to Tom> undefined variables. Tom> In the first hunk, I've changed the code to match what other Tom> 'complete' methods do in this file. Tom> In the second hunk, I've simply removed the try/except -- if Tom> get_filter_priority fails, it will raise GdbError, which is already Tom> handled properly by gdb. I'm checking this in. flake8 has pointed out some new errors, I'll send another fix for those. Tom