From: Tom Tromey <tom@tromey.com>
To: Tom de Vries <tdevries@suse.de>
Cc: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFC 1/3] [gdb/dap] Fix exit race
Date: Wed, 14 Feb 2024 09:18:20 -0700 [thread overview]
Message-ID: <87jzn73tpv.fsf@tromey.com> (raw)
In-Reply-To: <38759c3f-9a03-4468-9ddc-aa5ebb983074@suse.de> (Tom de Vries's message of "Wed, 14 Feb 2024 16:53:01 +0100")
>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
>> Ok. FWIW I think the Queue idea seems totally fine, and combining
>> these
>> patches seems natural to me.
Tom> Sorry for going on this topic, but I'd like to understand why you
Tom> think this.
My thinking is that the code is written this way to solve the flushing
issue (perhaps not well). Removing the quit fixes one issue, but it
risks introducing another. I'm not really a stickler for this though.
Tom
next prev parent reply other threads:[~2024-02-14 16:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 9:02 [RFC 0/3] [gdb/dap] Fix issues triggered by gdb.dap/eof.exp Tom de Vries
2024-02-07 9:02 ` [RFC 1/3] [gdb/dap] Fix exit race Tom de Vries
2024-02-07 16:01 ` Tom Tromey
2024-02-13 15:04 ` Tom de Vries
2024-02-13 18:04 ` Tom Tromey
2024-02-13 18:11 ` Tom Tromey
2024-02-14 15:31 ` Tom de Vries
2024-02-14 15:34 ` Tom Tromey
2024-02-14 15:53 ` Tom de Vries
2024-02-14 16:18 ` Tom Tromey [this message]
2024-02-14 17:16 ` Tom de Vries
2024-02-07 9:02 ` [RFC 2/3] [gdb/dap] Catch and log exceptions in dap threads Tom de Vries
2024-02-07 15:52 ` Tom Tromey
2024-02-12 15:15 ` Tom de Vries
2024-02-12 17:35 ` Tom Tromey
2024-02-07 9:02 ` [RFC 3/3] [gdb/dap] Ignore OSError on stream.flush in JSON writer Tom de Vries
2024-02-07 10:29 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzn73tpv.fsf@tromey.com \
--to=tom@tromey.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).