From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by sourceware.org (Postfix) with ESMTPS id AEDC73857C52 for ; Tue, 13 Feb 2024 22:16:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AEDC73857C52 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AEDC73857C52 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::429 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707862619; cv=none; b=Hhj+LlDwbtXkCAE3bh6genhIr2BCx7NqrcDfxwb48y8Z6ledt/Cxk/U+LaOtV4GBrhJVF6fezrfy2Y6WcGcD/cSvV6G62Y7MZ0w+DjeQqNLs/YGb2I/G1b83NOQ90kqVPtzwxHsJ3kS/n38KJfP7Am/TUPrksNJZnftbjwSpvhw= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1707862619; c=relaxed/simple; bh=Mjpymq9LDuIP1rsv6jB9Z2kcfXmh+RBsgAKfM+IAink=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=Y25UHXvhCTDG3WHz4I4jmdCZ9Bl2OqS6VRXVYAmqNZM4V2c7eP7DraU3U4FfUBn3YY5sb3D1MlcxIKrIhg/7+MDFAnhzb7xuNOh9KugmLjseRpzSMVLwmcSOBem29K2K2KcshEc8n1BObJy4C5UFN3T8yQrNPi8wXrM28oiGhF8= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-wr1-x429.google.com with SMTP id ffacd0b85a97d-33cda3dfa06so685655f8f.3 for ; Tue, 13 Feb 2024 14:16:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1707862616; x=1708467416; darn=sourceware.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=20h1Z7ZjfEnTeHjNvSc7YrYEqG3pbcYYhYh4vQv4Giw=; b=SjLwQgUCfDHmll+HI6M0RkoFsqDw9DpEG1Q9vcFbMbrbYjWJqdpiBDSkFZnU0llSVU kk2xyjXfZA8xpzkyOLXvRiEDK05iLi7GuREsD0KAq2aXmoR/3Pe459G5fGuc8oUw4i63 Zx1iyOMLV87XlEqtayaxigXg8kH07gkvFtvopOvoW0mx9NSMZBdi9Xly1Rnlu4G24K7W 2kEVlvxXKi00aIYL6ES3phLqygZ8xwre6Di2hv9TnJhcTbnWyfNZgaBOe071zjmMahmj 3l2XkkT1rMqAzB8e0cLyfkb3wFplAYo1Goj4ptCz7G9OmUHVpcNChK83woeR9Fi1CYXb deAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707862616; x=1708467416; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=20h1Z7ZjfEnTeHjNvSc7YrYEqG3pbcYYhYh4vQv4Giw=; b=EwyktuSTzCfFlrVPCgyyfqILFhZtdIOjDBx/vrrM20VqkswhHrrHzN3MTKR/xFT4xB r4yxkgb/usLNbC/RiL2/MB53RJF+v9aFUAf1Ohx/0u2cTOu62d+q0BbvOOdFf+7K7Qil Bd6kUyC2M3YN/xxJtlDfecIiDB9yoh2oqdyQqRu+KEvbxhN0NYw4rrfoqr1fave25RwV uuPF69aPx4NMYkaA3z0C2mOxrKlLCYAajeZwY3f78fLx4YmJFDjxhPyKGkCOLp4xHd+G 5D0ii9mMwj8WPmA4M+L+V6ivGj6vf/m1+49UwTN11xML4wwL3I5aQ2e6/03xWBSzdEeo /uUw== X-Gm-Message-State: AOJu0YwzQ+7jALVQt0NX7sWfNxFyhJs3GX8QcOOOxuE7ijJN7H63XsdI Lzi91rcLCQTDHBGskFefSnTpSGJsYAIZ1wxvriWY/weCYKvfw05OaLEPRKTzAsiyM7mM00nTyvy Law== X-Google-Smtp-Source: AGHT+IE4qJhHnZshAKEAQ3pzB+eM4s6Ln1PIf6bDnlk4KMN7T6WyrGO/V23ZEi1HVUvagtGXP3HDOw== X-Received: by 2002:adf:a1c1:0:b0:33b:1cb9:ca19 with SMTP id v1-20020adfa1c1000000b0033b1cb9ca19mr424086wrv.23.1707862616049; Tue, 13 Feb 2024 14:16:56 -0800 (PST) Received: from legouguec-Precision-7550 ([2a01:e0a:253:fe0:78e6:864d:c0d3:c625]) by smtp.gmail.com with ESMTPSA id v5-20020a5d59c5000000b0033b74a3dcf9sm9513467wry.27.2024.02.13.14.16.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Feb 2024 14:16:55 -0800 (PST) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 2/2] Add return value to DAP scope In-Reply-To: <87mss45mur.fsf@tromey.com> (Tom Tromey's message of "Tue, 13 Feb 2024 09:51:24 -0700") References: <20240212-dap-finish-v1-0-8e30870e8b25@adacore.com> <20240212-dap-finish-v1-2-8e30870e8b25@adacore.com> <87o7cke7d8.fsf@adacore.com> <87mss45mur.fsf@tromey.com> Date: Tue, 13 Feb 2024 23:16:55 +0100 Message-ID: <87jzn8dn6w.fsf@adacore.com> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Tom Tromey writes: >>>>>> "K=C3=A9vin" =3D=3D K=C3=A9vin Le Gouguec wr= ites: > >>> + def fetch_one_child(self, idx): >>> + global _last_return_value >>> + if _last_return_value is not None: >>> + if idx =3D=3D 0: >>> + return ("(return)", _last_return_value) >>> + idx =3D idx - 1 >>> + return super().fetch_one_child(idx) > > K=C3=A9vin> If scopes are cleared whenever the inferior is resumed (my pa= raphrasing > K=C3=A9vin> of =C2=A7 Lifetime of Objects References), can this method be= called after > K=C3=A9vin> _last_return_value has been reset to None? > > K=C3=A9vin> Wondering if the outer 'if' is necessary, since we only creat= e a > K=C3=A9vin> _FinishScopeReference when _last_return_value is not None: > > Ah yeah -- that 'if' is a leftover from an earlier iteration. Thanks. Pleasure's mine - v2 looks A-OK =F0=9F=91=8C > K=C3=A9vin> Tangentially, wondering if capturing _last_return_value as a > K=C3=A9vin> _FinishScopeReference.__init__ parameter would make sense. > > It doesn't really matter, because all these objects are only valid > during a single stop. Fair; plus I guess adding an attribute would add a second source of truth, so not a win overall.