From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta36.uswest2.a.cloudfilter.net (omta36.uswest2.a.cloudfilter.net [35.89.44.35]) by sourceware.org (Postfix) with ESMTPS id 9FE2D3858420 for ; Fri, 19 Jan 2024 17:14:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9FE2D3858420 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9FE2D3858420 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.35 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705684480; cv=none; b=erfOL9R+18K3ghdAlZMVKw+N66gj5A10laLsF6kEzWuwFmG/MtxNN6XU+KKjUWY+KBDCmezy8b4DSeiJQ9AbfCMrVkTM/Au97Hbnddpx0DPVK8F5wAKZ21WaRysJPMY9wPLLaGBu0MbnB6QJsYM5TV1iIHuNBE+tWg1OgKtQTrA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705684480; c=relaxed/simple; bh=oV34FWgkBQHNtpJMKUGjnsnfq8NWeqOEtPokUQplAfM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=WzaYQVVX2Rb+I6gs2lVM70Eavh50wMa4vzq2plcmv1CiV9XixIRWN0a1Cp2QOF9GQX5XZyz6LT37wvGz+rN4JjP3wJ959B+dew2R5w7fxfmXXDmKAQnE/wdUCLl7+2oT7CR3Vk51fNSoPh3B3rtshhcgr/r1qweongXRWIljQzI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5009a.ext.cloudfilter.net ([10.0.29.176]) by cmsmtp with ESMTPS id Qf6xrF8z5CF6GQsRxrzszW; Fri, 19 Jan 2024 17:14:37 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id QsRwrMNRXV9xYQsRwrTKkI; Fri, 19 Jan 2024 17:14:37 +0000 X-Authority-Analysis: v=2.4 cv=NfP1akP4 c=1 sm=1 tr=0 ts=65aaadfd a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=dEuoMetlWLkA:10 a=Qbun_eYptAEA:10 a=20KFwNOVAAAA:8 a=zstS-IiYAAAA:8 a=JM07N6XAND_WVu7JyngA:9 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=CMeH5K6JlGdE/1Et/5YPiKk4RDjxK6rtscAcIQ7Kha0=; b=cIJaXbyhpaJl1x9d5ptpsm80K2 eceIDoKSuPn3ZuRXT7gyb3qR4Fy1Q80OZwnRBBdE5eW2vTqVTcvgcR/z0h3IeLLd/UEZSH2JFhxyJ 8lIkCBqZjkuiolwXCnvEjBwJs; Received: from 97-122-68-157.hlrn.qwest.net ([97.122.68.157]:54916 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rQsRw-001gQB-0C; Fri, 19 Jan 2024 10:14:36 -0700 From: Tom Tromey To: Guinevere Larsen Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/testsuite: modernize gdb.dwarf2/dw2-noloc.exp References: <20240103171605.1048532-1-blarsen@redhat.com> X-Attribution: Tom Date: Fri, 19 Jan 2024 10:14:35 -0700 In-Reply-To: <20240103171605.1048532-1-blarsen@redhat.com> (Guinevere Larsen's message of "Wed, 3 Jan 2024 18:16:05 +0100") Message-ID: <87jzo5kzyc.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.68.157 X-Source-L: No X-Exim-ID: 1rQsRw-001gQB-0C X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-68-157.hlrn.qwest.net (murgatroyd) [97.122.68.157]:54916 X-Source-Auth: tom+tromey.com X-Email-Count: 4 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfNTCVmctr0+UGh/3tF32ZQUfdWybykR/ahxzK3xwtn64g7RJu8jbTBynwhCE2zv0orszjJRoIt54F3sCNWR2bbvMmV+p6D+eKTQks3okuLSW3GZb38mW PKtcWLievbDjqFjP2eOEWjUy9MM8rj6JITyjg0uBd158vaQZpXmjNEb4vdzi8/guNlXpvKmObovLE5yQ4TJGdX265hLCSW8kF1w= X-Spam-Status: No, score=-3016.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Guinevere" == Guinevere Larsen writes: Guinevere> The test gdb.dwarf2/dw2-noloc.exp predates the dwarf assembler, and uses Guinevere> some unreliable assumptions about where global labels get put. Guinevere> Specifically, when using clang to compile the test, both labels it uses Guinevere> to gauge the adresses of the main function get reshuffled to be side-by-side, Guinevere> and the debug information ends up making it look like main's high pc is equal Guinevere> to low pc, meaning we never enter the main function's scope, and that leads to Guinevere> 22 failures because the "main_*" variables are technically never in scope. Guinevere> This patch modernizes the aforementioned test to use the dwarf Guinevere> assembler, which removes all failures when using clang. It also renames Guinevere> the .c file to be more inline with current standard. Thank you for doing this. It's great whenever we can get rid of one of these .S files. Approved-By: Tom Tromey Tom