From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from omta40.uswest2.a.cloudfilter.net (omta40.uswest2.a.cloudfilter.net [35.89.44.39]) by sourceware.org (Postfix) with ESMTPS id D1C353858CD1 for ; Fri, 8 Dec 2023 18:28:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D1C353858CD1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D1C353858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=35.89.44.39 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702060123; cv=none; b=CkzYG9Vtll6HkZ2osHNCME8QlqM7wNLvWDWZ7DcMpApn1aZVujv26091VA5dUOdEtS1K1x9Qx8Iu1tlS2FMzKdRfA+W6Ai/RiDGvWEortQAsuH0v0MWbTUiQF2AdjND11J5PJSa2tyFNwL1ifqOtYxauh6R7l6GE4B3SEzT88lg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702060123; c=relaxed/simple; bh=83hmu7vqnbkfzV132PWLu2cpRF76DW0IdqoZJbzVTrM=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=q0nAErs0Nkr7M17VhgpY9BqnkO0DTrJi3agiQWpz0YoAedhEYlKi+B+oWo8MNdx9e/8rvZDgIvyi2vfvapnN5STi5ey/6JlBJAphML6PHBaTswBVrgc1+/WFiDxErJwwtUFAEVRLmxI4hoPvGJWKDhlRWICS/B8H6h0VzRAdubA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from eig-obgw-5008a.ext.cloudfilter.net ([10.0.29.246]) by cmsmtp with ESMTPS id BTu7r249eL9AgBfaZrMqFO; Fri, 08 Dec 2023 18:28:39 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id BfaYrzXPrkUbtBfaYrdyS3; Fri, 08 Dec 2023 18:28:38 +0000 X-Authority-Analysis: v=2.4 cv=WpU4jPTv c=1 sm=1 tr=0 ts=65736056 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=OWjo9vPv0XrRhIrVQ50Ab3nP57M=:19 a=dLZJa+xiwSxG16/P+YVxDGlgEgI=:19 a=e2cXIFwxEfEA:10 a=Qbun_eYptAEA:10 a=zstS-IiYAAAA:8 a=5oiAKWw6QxXEkM3N2bkA:9 a=4G6NA9xxw8l3yy4pmD5M:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References :Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ZkydBul7SJKQjRFrXXCEAZrU2+uvLl5dyvFkB3ckIXU=; b=CtoDVd31bV3Azhb/s6gMGSuFWi jGP2fdMBr0QUhKWUWlrG35niErrq+QMgIO0B0rdR1WdLv4zwVOuJ4AXW4BhNTBYK/nSEanQUffuSF CV8ZcZMrq7ndQ5Yexbut+2X71; Received: from 71-211-161-25.hlrn.qwest.net ([71.211.161.25]:35576 helo=murgatroyd) by box5379.bluehost.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1rBfaY-002fRs-0g; Fri, 08 Dec 2023 11:28:38 -0700 From: Tom Tromey To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH 00/19] Add hash table to gdbsupport References: <20230407-t-robin-hood-hash-v1-0-900d93ef1510@tromey.com> X-Attribution: Tom Date: Fri, 08 Dec 2023 11:28:37 -0700 In-Reply-To: <20230407-t-robin-hood-hash-v1-0-900d93ef1510@tromey.com> (Tom Tromey's message of "Fri, 07 Apr 2023 09:25:32 -0600") Message-ID: <87jzpoft0q.fsf@tromey.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 71.211.161.25 X-Source-L: No X-Exim-ID: 1rBfaY-002fRs-0g X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 71-211-161-25.hlrn.qwest.net (murgatroyd) [71.211.161.25]:35576 X-Source-Auth: tom+tromey.com X-Email-Count: 8 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfDs476dMT9I8ZMGehsChSSMNVbXqkvpxCl6DqLS6Qb/G8J1GXlY9o62g79qlWWDr0y/MR68glNYkBquW6wvxmZmw1gTLJXYeMG2G9RchBpxpcARjxT2c 2EbhGnt6IxkF0wuwIVJIk9gSQ9iW7qxzc6EJ1b5EIxOiqqUjMpsfEI1qD+k9weWlYOmOjpQGcRERSKUPU2AJCzgsuVl9Rgf59A8= X-Spam-Status: No, score=-3016.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,JMQ_SPF_NEUTRAL,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: >>>>> "Tom" == Tom Tromey writes: Tom> I recently read an article about hash tables and was inspired to write Tom> a new one for gdb. I haven't converted all the libiberty htab uses in Tom> gdb, but this series does change enough of them to, I think, show that Tom> the new implementation is workable. Tom> The benefits of this approach are explained in the first patch. Tom> Regression tested on x86-64 Fedora 36. This found a latent bug in one Tom> use of htab_t, see the typedefs patch. Tom> Let me know what you think. I'd like to move forward with this. I think most of the patches here are straightforward. The real question is whether we want it. I've laid out my rationale in patch #1, with some additions (explaining why this is better than unordered_map / unordered_set) in a follow-up email. Tom